Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 548263002: [CSSGridLayout] Resolved value of grid-template-* to include every track (Closed)

Created:
6 years, 3 months ago by svillar
Modified:
6 years, 3 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, jfernandez, Manuel Rego, rwlbuis, rune+blink, svillar
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[CSSGridLayout] Resolved value of grid-template-* to include every track Section 5.1.5 of the specs clearly states that the resolved value for grid-template-{columns|rows} must include every listed track, whether explicitly or implicitly created. We were only listing the explicit grid tracks. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -19 lines) Patch
M LayoutTests/fast/css-grid-layout/grid-auto-columns-rows-get-set.html View 1 chunk +30 lines, -9 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-auto-columns-rows-get-set-expected.txt View 1 chunk +24 lines, -6 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/resources/grid-definitions-parsing-utils.js View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +13 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
svillar
Adding reviewers
6 years, 3 months ago (2014-09-08 10:46:28 UTC) #2
Julien - ping for review
lgtm
6 years, 3 months ago (2014-09-08 21:05:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svillar@igalia.com/548263002/1
6 years, 3 months ago (2014-09-08 21:06:54 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-08 22:07:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181579

Powered by Google App Engine
This is Rietveld 408576698