Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 548253002: Revert of Forward input and compositing tasks to the Blink scheduler (Closed)

Created:
6 years, 3 months ago by jam
Modified:
6 years, 3 months ago
CC:
chromium-reviews, jam, cc-bugs_chromium.org, jdduke+watch_chromium.org, darin-cc_chromium.org, mithro-old
Project:
chromium
Visibility:
Public.

Description

Revert of Forward input and compositing tasks to the Blink scheduler (patchset #21 id:400001 of https://codereview.chromium.org/363383002/) Reason for revert: suspecting it's causing the high rate of flakes in Instrumentation test ContentShellTest BUG=411756 Original issue's description: > Forward input and compositing tasks to the Blink scheduler > > Instead of posting input and compositor tasks directly to the > main thread message loop, forward them to the Blink scheduler > so they can be prioritized over other tasks. > > BUG=391005 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290845 > > Committed: https://chromium.googlesource.com/chromium/src/+/68bab3290b45a8610ad875d3c92530477c16a948 TBR=jamesr@chromium.org,alexclarke@chromium.org,picksi@chromium.org,eseidel@chromium.org,skyostil@chromium.org NOTREECHECKS=true NOTRY=true BUG=391005 Committed: https://crrev.com/410d6b1f38af9f17048ec2b2458615e26580b77c Cr-Commit-Position: refs/heads/master@{#293686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -225 lines) Patch
M content/content_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 2 chunks +7 lines, -11 lines 0 comments Download
M content/renderer/input/input_event_filter.h View 3 chunks +3 lines, -6 lines 0 comments Download
M content/renderer/input/input_event_filter.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M content/renderer/input/input_event_filter_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.h View 3 chunks +0 lines, -10 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 6 chunks +2 lines, -13 lines 0 comments Download
D content/renderer/scheduler_proxy_task_runner.h View 1 chunk +0 lines, -87 lines 0 comments Download
D content/renderer/scheduler_proxy_task_runner_browsertest.cc View 1 chunk +0 lines, -85 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
Created Revert of Forward input and compositing tasks to the Blink scheduler
6 years, 3 months ago (2014-09-08 07:00:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/548253002/1
6 years, 3 months ago (2014-09-08 07:14:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 66f85d5405417e6ddd11e1b9be677062a2e3ae4f
6 years, 3 months ago (2014-09-08 07:22:24 UTC) #3
jam
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/548333002/ by jam@chromium.org. ...
6 years, 3 months ago (2014-09-08 14:36:47 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:45:01 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/410d6b1f38af9f17048ec2b2458615e26580b77c
Cr-Commit-Position: refs/heads/master@{#293686}

Powered by Google App Engine
This is Rietveld 408576698