tools/auto_bisect/mock_wrapper.py - Issue 548233002: Add a module to fetch builds from different types of builders.

Side by Side Diff: tools/auto_bisect/mock_wrapper.py

Issue 548233002: Add a module to fetch builds from different types of builders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2014 The Chromium Authors. All rights reserved.
	ghost stip (do not use) 2014/09/17 00:12:08 this is just a workaround to get pylint to stop co this is just a workaround to get pylint to stop complaining? we can probably remove this and cloud_storage_wrapper.py and just fix our pylint invocation qyearsley 2014/09/18 22:58:59 This was intended as a way to make the import sect Show quoted text On 2014/09/17 00:12:08, stip wrote: > this is just a workaround to get pylint to stop complaining? we can probably > remove this and cloud_storage_wrapper.py and just fix our pylint invocation This was intended as a way to make the import sections at the top of fetch_build.py and fetch_build_test.py look nicer; otherwise I think I'd have to modify sys.path at the top of those files. Doing it this way, mock can be imported in all of the tests in this directory without having to add a statement modifying sys.path at the top of all of the test files. (I'm not sure if this is the best way to do this though.) ghost stip (do not use) 2014/09/18 23:05:52 Stuff will either be run with a proper PYTHONPATH, Show quoted text On 2014/09/18 22:58:59, qyearsley wrote: > On 2014/09/17 00:12:08, stip wrote: > > this is just a workaround to get pylint to stop complaining? we can probably > > remove this and cloud_storage_wrapper.py and just fix our pylint invocation > > This was intended as a way to make the import sections at the top of > fetch_build.py and fetch_build_test.py look nicer; otherwise I think I'd have to > modify sys.path at the top of those files. > > Doing it this way, mock can be imported in all of the tests in this directory > without having to add a statement modifying sys.path at the top of all of the > test files. > > (I'm not sure if this is the best way to do this though.) Stuff will either be run with a proper PYTHONPATH, and if it's not you should look at add_build_paths() in https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/tools.... See it in action in https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave... qyearsley 2014/09/24 03:34:31 Hey, I didn't really understand what you're sugges Show quoted text On 2014/09/18 23:05:52, stip wrote: > On 2014/09/18 22:58:59, qyearsley wrote: > > On 2014/09/17 00:12:08, stip wrote: > > > this is just a workaround to get pylint to stop complaining? we can probably > > > remove this and cloud_storage_wrapper.py and just fix our pylint invocation > > > > This was intended as a way to make the import sections at the top of > > fetch_build.py and fetch_build_test.py look nicer; otherwise I think I'd have > to > > modify sys.path at the top of those files. > > > > Doing it this way, mock can be imported in all of the tests in this directory > > without having to add a statement modifying sys.path at the top of all of the > > test files. > > > > (I'm not sure if this is the best way to do this though.) > > Stuff will either be run with a proper PYTHONPATH, and if it's not you should > look at add_build_paths() in > https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/tools.... > See it in action in > https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave... Hey, I didn't really understand what you're suggesting I do here. I don't think that the PYTHONPATH is set up to include telemetry and pymock when the bisect script is run on the bisect bots, although I'm not fully sure. Are you suggesting that I should change something somewhere else and then assume that the python path includes pymock and telemetry here?
	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 """An intermediary used to import the third-party mock module."""

	6

	7 import os

	8 import sys

	9

	10 sys.path.append(os.path.join(

	11 os.path.dirname(__file__), os.path.pardir, os.path.pardir,

	12 'third_party', 'pymock'))

	13

	14 # Pylint is unable to import (F0401) because pylint doesn't modify sys.path.

	15 # A wildcard import is used below (W0401) to get everything from the module.

	16 # pylint: disable=F0401,W0401

	17 from mock import *

	18

OLD	NEW

« tools/auto_bisect/fetch_build_test.py ('K') | « tools/auto_bisect/fetch_build_test.py ('k') | no next file » | no next file with comments »