tools/auto_bisect/cloud_storage_wrapper.py - Issue 548233002: Add a module to fetch builds from different types of builders.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/auto_bisect/cloud_storage_wrapper.py

Issue 548233002: Add a module to fetch builds from different types of builders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2014 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 """An intermediary used to import the third-party cloud_storage module."""

	6

	7 import os

	8 import sys

	9

	10 sys.path.append(os.path.join(

	11 os.path.dirname(__file__), os.path.pardir, os.path.pardir,

	12 'telemetry'))

	13

	14 # Pylint is unable to import (F0401) because pylint doesn't modify sys.path.

	15 # A wildcard import is used below (W0401) to get everything from the module.

	16 # The names imported here are not used in this module (W0614).

	17 # pylint: disable=F0401,W0401,W0614

	18 from telemetry.util.cloud_storage import *
	ghost stip (do not use) 2014/09/17 00:12:08 usually importing * is a bad idea. usually importing * is a bad idea. qyearsley 2014/09/18 22:58:58 Changed this to import just the functions that are Show quoted text On 2014/09/17 00:12:08, stip wrote: > usually importing * is a bad idea. Changed this to import just the functions that are being used from cloud_storage: Exists and Get.
	19

OLD	NEW

« tools/auto_bisect/bisect_utils.py ('K') | « tools/auto_bisect/bisect_utils.py ('k') | tools/auto_bisect/fetch_build.py » ('j') | tools/auto_bisect/fetch_build.py » ('J')