Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: tools/auto_bisect/PRESUBMIT.py

Issue 548233002: Add a module to fetch builds from different types of builders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove print in run_tests and move changes to sys.path into main. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/auto_bisect/bisect_utils.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for auto-bisect. 5 """Top-level presubmit script for auto-bisect.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
8 details on the presubmit API. 8 details on the presubmit API.
9 """ 9 """
10 10
11 import imp 11 import imp
12 import subprocess 12 import subprocess
13 import os 13 import os
14 14
15 # Paths to bisect config files relative to src/tools. 15 # Paths to bisect config files relative to src/tools.
16 CONFIG_FILES = [ 16 CONFIG_FILES = [
17 'auto_bisect/config.cfg', 17 'auto_bisect/config.cfg',
18 'run-perf-test.cfg' 18 'run-perf-test.cfg'
19 ] 19 ]
20 20
21
21 def CheckChangeOnUpload(input_api, output_api): 22 def CheckChangeOnUpload(input_api, output_api):
22 return _CommonChecks(input_api, output_api) 23 return _CommonChecks(input_api, output_api)
23 24
24 25
25 def CheckChangeOnCommit(input_api, output_api): 26 def CheckChangeOnCommit(input_api, output_api):
26 return _CommonChecks(input_api, output_api) 27 return _CommonChecks(input_api, output_api)
27 28
28 29
29 def _CommonChecks(input_api, output_api): 30 def _CommonChecks(input_api, output_api):
30 """Does all presubmit checks for auto-bisect.""" 31 """Does all presubmit checks for auto-bisect."""
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 if return_code: 82 if return_code:
82 message = 'Auto-bisect unit tests did not all pass.' 83 message = 'Auto-bisect unit tests did not all pass.'
83 return [output_api.PresubmitError(message)] 84 return [output_api.PresubmitError(message)]
84 return [] 85 return []
85 86
86 87
87 def _RunPyLint(input_api, output_api): 88 def _RunPyLint(input_api, output_api):
88 """Runs unit tests for auto-bisect.""" 89 """Runs unit tests for auto-bisect."""
89 telemetry_path = os.path.join( 90 telemetry_path = os.path.join(
90 input_api.PresubmitLocalPath(), os.path.pardir, 'telemetry') 91 input_api.PresubmitLocalPath(), os.path.pardir, 'telemetry')
92 mock_path = os.path.join(
93 input_api.PresubmitLocalPath(),os.path.pardir, os.path.pardir,
94 'third_party', 'pymock')
91 tests = input_api.canned_checks.GetPylint( 95 tests = input_api.canned_checks.GetPylint(
92 input_api, output_api, extra_paths_list=[telemetry_path]) 96 input_api, output_api, extra_paths_list=[telemetry_path, mock_path])
93 return input_api.RunTests(tests) 97 return input_api.RunTests(tests)
98
OLDNEW
« no previous file with comments | « no previous file | tools/auto_bisect/bisect_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698