Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1518)

Issue 548183002: Added SigninManager.isSignInDisabledByPolicy. (Closed)

Created:
6 years, 3 months ago by Joao da Silva
Modified:
6 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added SigninManager.isSignInDisabledByPolicy. BUG=398378 Committed: https://crrev.com/a0d4f47fc6de371aa7e54c4b6aca378afbdb0892 Cr-Commit-Position: refs/heads/master@{#293734}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Joao da Silva
PTAL, thanks!
6 years, 3 months ago (2014-09-07 13:32:19 UTC) #2
Bernhard Bauer
Heh. I worked on the exact same change for http://crbug.com/410729 :) I had isSigninAllowedByPolicy(), but ...
6 years, 3 months ago (2014-09-08 08:07:58 UTC) #3
Joao da Silva
https://codereview.chromium.org/548183002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java File chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java (right): https://codereview.chromium.org/548183002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java#newcode147 chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java:147: public boolean isSignInDisabledByPolicy() { On 2014/09/08 08:07:58, Bernhard Bauer ...
6 years, 3 months ago (2014-09-08 14:39:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/548183002/20001
6 years, 3 months ago (2014-09-08 14:41:49 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 3a7ffba366b148bc3b3fdcd9bd1d074878f71a33
6 years, 3 months ago (2014-09-08 15:49:20 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:46:34 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a0d4f47fc6de371aa7e54c4b6aca378afbdb0892
Cr-Commit-Position: refs/heads/master@{#293734}

Powered by Google App Engine
This is Rietveld 408576698