Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 548153004: Unified BeginFrame scheduling (Closed)

Created:
6 years, 3 months ago by mithro-old
Modified:
6 years, 2 months ago
Reviewers:
brianderson, Sami
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, nasko+codewatch_chromium.org, sievers+watch_chromium.org, yukishiino+watch_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, jam, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, miu+watch_chromium.org, creis+watch_chromium.org, penghuang+watch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, Ian Vollick, ben+ash_chromium.org, cc-bugs_chromium.org, James Su, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Unified BeginFrame scheduling This CL is initial implementation for "Unified BeginFrame scheduling on chrome". Scheduler is divided into publisher(live in browser compositor) and receiver(live in renderer compositor). Newly created BeginFrameManager(which owned by browser compositor) will act like router between Scheduler and RWHV for delivering BeginFrame messages. Browser compositor's scheduler(publisher) triggers next BeginFrame for itself(ui) and renderers(receiver). Please refer to below docs for overall design. (https://docs.google.com/a/chromium.org/document/d/13xtO-_NSSnNZRRS1Xq3xGNKZawKc8HQxOid5boBUyX8/edit#) Original CL at https://codereview.chromium.org/423773002/ R=brianderson@chromium.org, skyostil@chromium.org BUG=372086

Patch Set 1 : Simon Hong's original patch. #

Patch Set 2 : Rebasing into master and making compile. #

Patch Set 3 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+650 lines, -345 lines) Patch
M ash/display/display_controller.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M cc/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/cc.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/output/begin_frame_args.h View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M cc/output/output_surface.h View 1 2 chunks +9 lines, -2 lines 0 comments Download
M cc/output/output_surface.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M cc/scheduler/scheduler.h View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M cc/scheduler/scheduler.cc View 1 2 9 chunks +51 lines, -11 lines 0 comments Download
M cc/scheduler/scheduler_settings.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/scheduler/scheduler_settings.cc View 1 2 4 chunks +10 lines, -4 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 1 2 4 chunks +26 lines, -3 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 1 2 5 chunks +8 lines, -6 lines 0 comments Download
M cc/test/begin_frame_args_test.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M cc/test/begin_frame_args_test.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M cc/test/fake_layer_tree_host_client.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 2 2 chunks +14 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_client.h View 1 3 chunks +5 lines, -1 line 0 comments Download
A cc/trees/layer_tree_host_client.cc View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_no_message_loop.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +4 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/proxy.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/proxy.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 2 2 chunks +13 lines, -0 lines 0 comments Download
M cc/trees/thread_proxy.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.h View 4 chunks +2 lines, -11 lines 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.cc View 1 4 chunks +5 lines, -19 lines 0 comments Download
M content/browser/compositor/delegated_frame_host.h View 1 5 chunks +2 lines, -9 lines 0 comments Download
M content/browser/compositor/delegated_frame_host.cc View 1 6 chunks +6 lines, -23 lines 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.cc View 1 2 1 chunk +1 line, -5 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 3 chunks +2 lines, -12 lines 0 comments Download
M content/browser/compositor/software_browser_compositor_output_surface.h View 2 chunks +1 line, -6 lines 0 comments Download
M content/browser/compositor/software_browser_compositor_output_surface.cc View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
M content/browser/compositor/software_browser_compositor_output_surface_unittest.cc View 1 2 1 chunk +1 line, -5 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/display_link_mac.h View 4 chunks +12 lines, -0 lines 0 comments Download
M content/browser/renderer_host/display_link_mac.cc View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 6 chunks +20 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 9 chunks +77 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 5 chunks +28 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 9 chunks +61 lines, -11 lines 0 comments Download
M content/common/view_messages.h View 1 2 4 chunks +12 lines, -10 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.cc View 1 4 chunks +1 line, -7 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 1 chunk +7 lines, -2 lines 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/examples/compositor_app/compositor_host.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/examples/compositor_app/compositor_host.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/base/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/android/window_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
A ui/base/compositor/compositor_begin_frame_observer.h View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
M ui/base/ui_base.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ui/compositor/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/compositor.h View 1 9 chunks +35 lines, -7 lines 0 comments Download
M ui/compositor/compositor.cc View 1 2 11 chunks +92 lines, -6 lines 0 comments Download
M ui/compositor/compositor.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ui/compositor/compositor_vsync_manager.h View 1 1 chunk +0 lines, -71 lines 0 comments Download
M ui/compositor/compositor_vsync_manager.cc View 1 1 chunk +0 lines, -63 lines 0 comments Download

Messages

Total messages: 2 (2 generated)
mithro-old
Patchset #2 (id:20001) has been deleted
6 years, 3 months ago (2014-09-09 11:45:15 UTC) #1
mithro-old
6 years, 3 months ago (2014-09-09 11:51:09 UTC) #2 
Patchset #2 (id:40001) has been deleted

Powered by Google App Engine
This is Rietveld 408576698