Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 548113002: [trivial] Remove RenderBox::MarginSign (Closed)

Created:
6 years, 3 months ago by pdr.
Modified:
6 years, 3 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Project:
blink
Visibility:
Public.

Description

[trivial] Remove RenderBox::MarginSign This patch removes the unused MarginSign enum. I noticed this while searching how we name enums in Blink as part of another patch. Since I was in the area, I fixed the comment about margins as well. R=esprehn Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181528

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/core/rendering/RenderBox.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
pdr.
6 years, 3 months ago (2014-09-07 04:28:13 UTC) #1
esprehn
rslgtm
6 years, 3 months ago (2014-09-07 07:14:11 UTC) #2
esprehn
lgtm
6 years, 3 months ago (2014-09-07 07:14:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/548113002/1
6 years, 3 months ago (2014-09-07 18:38:34 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-07 19:16:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181528

Powered by Google App Engine
This is Rietveld 408576698