Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 548083002: re2: Merge upstream 2225f94df8ec (Closed)

Created:
6 years, 3 months ago by Nico
Modified:
6 years, 3 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

re2: Merge upstream 2225f94df8ec BUG=411648 TBR=hans@chromium.org Committed: https://crrev.com/ed5176ba319a6a8ca6fdbe016ce861dd09ac6f19 Cr-Commit-Position: refs/heads/master@{#293652}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M third_party/re2/README.chromium View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/re2/lib/codereview/codereview.py View 2 chunks +5 lines, -2 lines 2 comments Download
M third_party/re2/util/util.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Nico
6 years, 3 months ago (2014-09-07 02:53:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/548083002/40001
6 years, 3 months ago (2014-09-07 02:55:12 UTC) #4
hans
https://codereview.chromium.org/548083002/diff/40001/third_party/re2/lib/codereview/codereview.py File third_party/re2/lib/codereview/codereview.py (right): https://codereview.chromium.org/548083002/diff/40001/third_party/re2/lib/codereview/codereview.py#newcode717 third_party/re2/lib/codereview/codereview.py:717: return ui.promptchoice(msg, ["&yes", "&no"], 0) == 0 Was merging ...
6 years, 3 months ago (2014-09-07 03:09:20 UTC) #5
Nico
https://codereview.chromium.org/548083002/diff/40001/third_party/re2/lib/codereview/codereview.py File third_party/re2/lib/codereview/codereview.py (right): https://codereview.chromium.org/548083002/diff/40001/third_party/re2/lib/codereview/codereview.py#newcode717 third_party/re2/lib/codereview/codereview.py:717: return ui.promptchoice(msg, ["&yes", "&no"], 0) == 0 On 2014/09/07 ...
6 years, 3 months ago (2014-09-07 03:11:25 UTC) #6
hans
On 2014/09/07 03:11:25, Nico (hiding) wrote: > https://codereview.chromium.org/548083002/diff/40001/third_party/re2/lib/codereview/codereview.py > File third_party/re2/lib/codereview/codereview.py (right): > > https://codereview.chromium.org/548083002/diff/40001/third_party/re2/lib/codereview/codereview.py#newcode717 ...
6 years, 3 months ago (2014-09-07 03:12:43 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as e5b571b0e2813641d55fec491c63ede1fcf393e2
6 years, 3 months ago (2014-09-07 04:39:01 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:43:54 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/ed5176ba319a6a8ca6fdbe016ce861dd09ac6f19
Cr-Commit-Position: refs/heads/master@{#293652}

Powered by Google App Engine
This is Rietveld 408576698