Source/core/editing/ReplaceSelectionCommand.h - Issue 54803003: Have Node::lastDescendant() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/ReplaceSelectionCommand.h

Issue 54803003: Have Node::lastDescendant() return a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Kill firstDescendant()! Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/ReplaceSelectionCommand.h

diff --git a/Source/core/editing/ReplaceSelectionCommand.h b/Source/core/editing/ReplaceSelectionCommand.h

index b6eacc700190dd8efbd28142312af49c2133e8c8..b9f5da64f6f4004e1d9978e89f7a9f973cd1588c 100644

--- a/Source/core/editing/ReplaceSelectionCommand.h

+++ b/Source/core/editing/ReplaceSelectionCommand.h

@@ -66,8 +66,8 @@ private:

void didReplaceNode(Node*, Node* newNode);

Node* firstNodeInserted() const { return m_firstNodeInserted.get(); }

- Node* lastLeafInserted() const { return m_lastNodeInserted->lastDescendant(); }

- Node* pastLastLeaf() const { return m_lastNodeInserted ? NodeTraversal::next(lastLeafInserted()) : 0; }

+ Node& lastLeafInserted() const { ASSERT(m_lastNodeInserted); return m_lastNodeInserted->lastDescendant(); }

+ Node* pastLastLeaf() const { return m_lastNodeInserted ? NodeTraversal::next(&lastLeafInserted()) : 0; }

private:

RefPtr<Node> m_firstNodeInserted;