Have Node::lastDescendant() return a reference

Have Node::lastDescendant() return a reference

Have Node::lastDescendant() return a reference instead of a pointer
as it can never return null. It makes the calling code look safer
and gets rid of several unnecessary null checks.

Also get rid of Node::firstDescendant() which is unused.

R=adamk

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161096

[adamk, 2013-10-31 16:27:42]

lgtm, but it seems like making firstDescendent() return a reference should be
done ASAP just for consistency (in this patch would be even better).

[Inactive, 2013-10-31 16:38:44]

On 2013/10/31 16:27:42, adamk wrote:
> lgtm, but it seems like making firstDescendent() return a reference should be
> done ASAP just for consistency (in this patch would be even better).

Done. BTW, firstDescendant() is unused(). Should we really keep it?

[adamk, 2013-10-31 20:14:23]

On 2013/10/31 16:38:44, Chris Dumez wrote:
> On 2013/10/31 16:27:42, adamk wrote:
> > lgtm, but it seems like making firstDescendent() return a reference should
be
> > done ASAP just for consistency (in this patch would be even better).
> 
> Done. BTW, firstDescendant() is unused(). Should we really keep it?

Kill it then! Thanks!

still lgtm

[Inactive, 2013-10-31 20:23:36]

On 2013/10/31 20:14:23, adamk wrote:
> On 2013/10/31 16:38:44, Chris Dumez wrote:
> > On 2013/10/31 16:27:42, adamk wrote:
> > > lgtm, but it seems like making firstDescendent() return a reference should
> be
> > > done ASAP just for consistency (in this patch would be even better).
> > 
> > Done. BTW, firstDescendant() is unused(). Should we really keep it?
> 
> Kill it then! Thanks!
> 
> still lgtm

Done

[commit-bot: I haz the power, 2013-10-31 20:23:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/54803003/160001

[commit-bot: I haz the power, 2013-10-31 21:37:24]

Change committed as 161096