Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Unified Diff: media/base/media_log.cc

Issue 547913002: MediaLog: Log selected audio/video decoder name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase only Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/media_log.cc
diff --git a/media/base/media_log.cc b/media/base/media_log.cc
index b172bfbce912f828f4896769a215f1d7658a6877..4f38f6c41ad4472b72aedb4623f548e88df9c177 100644
--- a/media/base/media_log.cc
+++ b/media/base/media_log.cc
@@ -56,6 +56,8 @@ const char* MediaLog::EventTypeToString(MediaLogEvent::Type type) {
return "MEDIA_SOURCE_ERROR";
case MediaLogEvent::PROPERTY_CHANGE:
return "PROPERTY_CHANGE";
+ case MediaLogEvent::INFO:
+ return "INFO";
}
NOTREACHED();
return NULL;
@@ -199,6 +201,12 @@ scoped_ptr<MediaLogEvent> MediaLog::CreateMediaSourceErrorEvent(
return event.Pass();
}
+scoped_ptr<MediaLogEvent> MediaLog::CreateInfoEvent(const std::string& info) {
+ scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::INFO));
+ event->params.SetString("INFO", info);
xhwang 2014/09/08 17:31:21 Note we have "error" above. Not sure whether we sh
+ return event.Pass();
+}
+
void MediaLog::SetStringProperty(
const char* key, const std::string& value) {
scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PROPERTY_CHANGE));

Powered by Google App Engine
This is Rietveld 408576698