Source/platform/heap/Heap.cpp - Issue 547903002: Oilpan: blink_heap_unittests: asan check failed. HeapObjectHeader::finalize zap a wrong memory for …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/Heap.cpp

Issue 547903002: Oilpan: blink_heap_unittests: asan check failed. HeapObjectHeader::finalize zap a wrong memory for … (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/heap/Heap.cpp

diff --git a/Source/platform/heap/Heap.cpp b/Source/platform/heap/Heap.cpp

index c8e359c17277a8a700cbd1c404dcbfc10df98b35..3b593341fb132806be33f8dc7cc3c43f01df7149 100644

--- a/Source/platform/heap/Heap.cpp

+++ b/Source/platform/heap/Heap.cpp

@@ -484,7 +484,9 @@ void HeapObjectHeader::finalize(const GCInfo* gcInfo, Address object, size_t obj

object[i] = finalizedZapValue;

// Zap the primary vTable entry (secondary vTable entries are not zapped).

- *(reinterpret_cast<uintptr_t*>(object)) = zappedVTable;

+ if (gcInfo->hasVTable()) {

+ *(reinterpret_cast<uintptr_t*>(object)) = zappedVTable;

+ }

#endif

// In Release builds, the entire object is zeroed out when it is added to the free list.

// This happens right after sweeping the page and before the thread commences execution.

« no previous file with comments | « no previous file | no next file » | no next file with comments »