Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 547883002: GN: Build libvpx on ARM (Closed)

Created:
6 years, 3 months ago by Alpha Left Google
Modified:
6 years, 3 months ago
Reviewers:
Tom Finegan
CC:
chromium-reviews, wwcv, jzern, fgalligan1
Visibility:
Public.

Description

GN: Build libvpx on ARM My previous patch didn't work. Shouldn't use media_use_libvpx because it's in third_party. Instead I just commented out the entire target for NEON intrinsics. TBR=tomfinegan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291844

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M BUILD.gn View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Alpha Left Google
Committed patchset #1 (id:1) manually as r291844 (presubmit successful).
6 years, 3 months ago (2014-09-06 03:05:24 UTC) #1
Tom Finegan
6 years, 3 months ago (2014-09-09 20:02:00 UTC) #2
Message was sent while issue was closed.
On 2014/09/06 03:05:24, Alpha wrote:
> Committed patchset #1 (id:1) manually as r291844 (presubmit successful).

lgtm

Powered by Google App Engine
This is Rietveld 408576698