Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 547863002: Fix uninitialized value in CPDF_ColorStateData (Closed)

Created:
6 years, 3 months ago by Bo Xu
Modified:
5 years, 9 months ago
Reviewers:
Tom Sepez, jun_fang
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M core/include/fpdfapi/fpdf_pageobj.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Bo Xu
Hi Tom, please review this one.
6 years, 3 months ago (2014-09-06 00:57:40 UTC) #2
Tom Sepez
LGTM.
6 years, 3 months ago (2014-09-08 17:45:50 UTC) #3
Bo Xu
Committed patchset #1 (id:1) manually as a38d4c3 (presubmit successful).
6 years, 3 months ago (2014-09-09 00:34:59 UTC) #4
Bo Xu
6 years, 3 months ago (2014-09-10 00:30:37 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/558803004/ by bo_xu@foxitsoftware.com.

The reason for reverting is: The initialized member variable is wrong. Needs to
undo this..

Powered by Google App Engine
This is Rietveld 408576698