Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 547843002: Revert "net: enable SSL_MODE_CBC_RECORD_SPLITTING with OpenSSL." (Closed)

Created:
6 years, 3 months ago by agl
Modified:
6 years, 3 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "net: enable SSL_MODE_CBC_RECORD_SPLITTING with OpenSSL." This reverts commit e06bd13395c1ed5d93dd35ff3572a79f08bfbab8. This is a preemptive revert to see whether a pagecycler regression can be attributed to this change. (Even if it can, we still probably want to make the change, but it's good to know.) BUG=409214 TBR=davidben@chromium.org Committed: https://crrev.com/ab30262824c73a9e02467dd6bdb4c330c8a27872 Cr-Commit-Position: refs/heads/master@{#293617}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M net/socket/ssl_client_socket_openssl.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/547843002/1
6 years, 3 months ago (2014-09-06 00:02:16 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/5982)
6 years, 3 months ago (2014-09-06 01:58:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/547843002/1
6 years, 3 months ago (2014-09-06 02:29:46 UTC) #6
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 12:17:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/547843002/1
6 years, 3 months ago (2014-09-06 13:02:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5fee53e7fe9a5a0f6aeb568446d8cdee5e3a96b7
6 years, 3 months ago (2014-09-06 14:33:32 UTC) #11
Ilya Sherman
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/559663003/ by isherman@chromium.org. ...
6 years, 3 months ago (2014-09-09 20:11:10 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:42:36 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab30262824c73a9e02467dd6bdb4c330c8a27872
Cr-Commit-Position: refs/heads/master@{#293617}

Powered by Google App Engine
This is Rietveld 408576698