Source/core/html/forms/TextFieldInputType.cpp - Issue 547823002: Track reasons for |Node::SetNeedsStyleRecalc|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/TextFieldInputType.cpp

Issue 547823002: Track reasons for |Node::SetNeedsStyleRecalc| (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: reasons as tuple Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/forms/TextFieldInputType.cpp

diff --git a/Source/core/html/forms/TextFieldInputType.cpp b/Source/core/html/forms/TextFieldInputType.cpp

index 67866290bfacd113fe0f8324473eed59a8d82005..4821fdc23c7446a7bbbf784a944913be537256c0 100644

--- a/Source/core/html/forms/TextFieldInputType.cpp

+++ b/Source/core/html/forms/TextFieldInputType.cpp

@@ -492,7 +492,7 @@ void TextFieldInputType::subtreeHasChanged()

element().setValueFromRenderer(sanitizeValue(convertFromVisibleValue(element().innerEditorValue())));

element().updatePlaceholderVisibility(false);

// Recalc for :invalid change.

- element().setNeedsStyleRecalc(SubtreeStyleChange);

+ element().setNeedsStyleRecalc(StyleChangeReasonForTracing::createWithExtraData(StyleChangeReason::PseudoClass, StyleChangeExtraData::Invalid), SubtreeStyleChange);

didSetValueByUserEdit(wasChanged ? ValueChangeStateChanged : ValueChangeStateNone);

}

« Source/core/dom/TreeScope.cpp ('K') | « Source/core/html/forms/RadioButtonGroupScope.cpp ('k') | Source/core/html/shadow/DateTimeEditElement.cpp » ('j') | no next file with comments »