Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp - Issue 547823002: Track reasons for |Node::SetNeedsStyleRecalc|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

Issue 547823002: Track reasons for |Node::SetNeedsStyleRecalc| (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: reasons as tuple Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

diff --git a/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp b/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

index e69333905268877e517eaef9052c967eab772f9d..3871cc4218dabd6ce542f9dadd414a8833d13e9c 100644

--- a/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

+++ b/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

@@ -189,7 +189,7 @@ void BaseMultipleFieldsDateAndTimeInputType::editControlValueChanged()

input->setNeedsValidityCheck();

} else {

input->setValueInternal(newValue, DispatchNoEvent);

- input->setNeedsStyleRecalc(SubtreeStyleChange);

+ input->setNeedsStyleRecalc(StyleChangeReasonForTracing::create(StyleChangeReason::ControlValue), SubtreeStyleChange);

input->dispatchFormControlInputEvent();

}

input->notifyFormStateChanged();