Source/core/html/HTMLObjectElement.cpp - Issue 547823002: Track reasons for |Node::SetNeedsStyleRecalc|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLObjectElement.cpp

Issue 547823002: Track reasons for |Node::SetNeedsStyleRecalc| (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: reasons as tuple Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLObjectElement.cpp

diff --git a/Source/core/html/HTMLObjectElement.cpp b/Source/core/html/HTMLObjectElement.cpp

index 3d588cdd406fedfea8d5204e2d01b0c788e2cd72..cb5a6d6954d6c2753494f7eaa0d7a523942bb049 100644

--- a/Source/core/html/HTMLObjectElement.cpp

+++ b/Source/core/html/HTMLObjectElement.cpp

@@ -256,7 +256,7 @@ void HTMLObjectElement::reloadPluginOnAttributeChange(const QualifiedName& name)

}

setNeedsWidgetUpdate(true);

if (needsInvalidation)

- setNeedsStyleRecalc(SubtreeStyleChange);

+ setNeedsStyleRecalc(StyleChangeReasonForTracing::create(StyleChangeReason::Plugin), SubtreeStyleChange);

}

// FIXME: This should be unified with HTMLEmbedElement::updateWidget and

@@ -331,7 +331,7 @@ void HTMLObjectElement::childrenChanged(const ChildrenChange& change)

{

if (inDocument() && !useFallbackContent()) {

setNeedsWidgetUpdate(true);

- setNeedsStyleRecalc(SubtreeStyleChange);

+ setNeedsStyleRecalc(StyleChangeReasonForTracing::create(StyleChangeReason::Plugin), SubtreeStyleChange);

}

HTMLPlugInElement::childrenChanged(change);

}