Source/core/dom/Node.cpp - Issue 547823002: Track reasons for |Node::SetNeedsStyleRecalc|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Node.cpp

Issue 547823002: Track reasons for |Node::SetNeedsStyleRecalc| (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: reasons as tuple Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Node.cpp

diff --git a/Source/core/dom/Node.cpp b/Source/core/dom/Node.cpp

index 7e59398c3c871cec8d40bcbda84b6212ed3f5953..3d09aed8bd7cbe368639744c96f8b170f40da946 100644

--- a/Source/core/dom/Node.cpp

+++ b/Source/core/dom/Node.cpp

@@ -767,7 +767,7 @@ void Node::markAncestorsWithChildNeedsStyleRecalc()

document().scheduleRenderTreeUpdateIfNeeded();

}

-void Node::setNeedsStyleRecalc(StyleChangeType changeType)

+void Node::setNeedsStyleRecalc(const StyleChangeReasonForTracing& reason, StyleChangeType changeType)

{

ASSERT(changeType != NoStyleChange);

if (!inActiveDocument())

@@ -2428,7 +2428,7 @@ void Node::setCustomElementState(CustomElementState newState)

setFlag(newState == Upgraded, CustomElementUpgradedFlag);

if (oldState == NotCustomElement || newState == Upgraded)

- setNeedsStyleRecalc(SubtreeStyleChange); // :unresolved has changed

+ setNeedsStyleRecalc(StyleChangeReasonForTracing::createWithExtraData(StyleChangeReason::PseudoClass, StyleChangeExtraData::Unresolved), SubtreeStyleChange); // :unresolved has changed

}

void Node::trace(Visitor* visitor)

« no previous file with comments | « Source/core/dom/Node.h ('k') | Source/core/dom/ShadowTreeStyleSheetCollection.cpp » ('j') | Source/core/dom/StyleChangeReason.h » ('J')