Source/core/css/invalidation/StyleInvalidator.cpp - Issue 547823002: Track reasons for |Node::SetNeedsStyleRecalc|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/invalidation/StyleInvalidator.cpp

Issue 547823002: Track reasons for |Node::SetNeedsStyleRecalc| (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: reasons as tuple Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/css/PropertySetCSSStyleDeclaration.cpp ('k') | Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp » ('j') | Source/core/dom/StyleChangeReason.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/invalidation/StyleInvalidator.cpp

diff --git a/Source/core/css/invalidation/StyleInvalidator.cpp b/Source/core/css/invalidation/StyleInvalidator.cpp

index e237c9ae1a70081d237e993b3b6c134eea328f2d..0fd4fa6df97d7f34cef0099df9841ecdd540b1a5 100644

--- a/Source/core/css/invalidation/StyleInvalidator.cpp

+++ b/Source/core/css/invalidation/StyleInvalidator.cpp

@@ -145,13 +145,13 @@ bool StyleInvalidator::invalidate(Element& element, StyleInvalidator::RecursionD

someChildrenNeedStyleRecalc = invalidateChildren(element, recursionData);

if (thisElementNeedsStyleRecalc) {

- element.setNeedsStyleRecalc(recursionData.wholeSubtreeInvalid() ? SubtreeStyleChange : LocalStyleChange);

+ element.setNeedsStyleRecalc(StyleChangeReasonForTracing::create(StyleChangeReason::StyleInvalidator), recursionData.wholeSubtreeInvalid() ? SubtreeStyleChange : LocalStyleChange);

} else if (recursionData.hasInvalidationSets() && someChildrenNeedStyleRecalc) {

// Clone the RenderStyle in order to preserve correct style sharing, if possible. Otherwise recalc style.

if (RenderObject* renderer = element.renderer())

renderer->setStyleInternal(RenderStyle::clone(renderer->style()));

else

- element.setNeedsStyleRecalc(LocalStyleChange);

+ element.setNeedsStyleRecalc(StyleChangeReasonForTracing::create(StyleChangeReason::StyleInvalidator), LocalStyleChange);

}

element.clearChildNeedsStyleInvalidation();