Source/core/rendering/RenderObject.cpp - Issue 547823002: Track reasons for |Node::SetNeedsStyleRecalc|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderObject.cpp

Issue 547823002: Track reasons for |Node::SetNeedsStyleRecalc| (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: use const char[] Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderObject.cpp

diff --git a/Source/core/rendering/RenderObject.cpp b/Source/core/rendering/RenderObject.cpp

index 5519d5f9be98e814ad1a4e8efb77bc87de1cf4b7..9668e3e8fac7e34f6f097ca1503a0d62d11778e7 100644

--- a/Source/core/rendering/RenderObject.cpp

+++ b/Source/core/rendering/RenderObject.cpp

@@ -2836,9 +2836,9 @@ void RenderObject::updateDragState(bool dragOn)

setIsDragging(dragOn);

if (valueChanged && node()) {

if (node()->isElementNode() && toElement(node())->childrenOrSiblingsAffectedByDrag())

- node()->setNeedsStyleRecalc(SubtreeStyleChange);

+ node()->setNeedsStyleRecalc(StyleChangeReasonForTracing::Drag, SubtreeStyleChange);

else if (style()->affectedByDrag())

- node()->setNeedsStyleRecalc(LocalStyleChange);

+ node()->setNeedsStyleRecalc(StyleChangeReasonForTracing::Drag, LocalStyleChange);

}

for (RenderObject* curr = slowFirstChild(); curr; curr = curr->nextSibling())

curr->updateDragState(dragOn);