Track reasons for |Node::SetNeedsStyleRecalc|

Source/core/dom/Element.cpp

Index: Source/core/dom/Element.cpp
diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp
index 1f2fed69eefcbaeb8f6dd79a86194da9d66c3598..b10690fca392fd2916d3cd70105351b16a651b04 100644
--- a/Source/core/dom/Element.cpp
+++ b/Source/core/dom/Element.cpp
@@ -959,7 +959,7 @@ void Element::attributeChanged(const QualifiedName& name, const AtomicString& ne
         styleAttributeChanged(newValue, reason);
     } else if (isStyledElement() && isPresentationAttribute(name)) {
         elementData()->m_presentationAttributeStyleIsDirty = true;
-        setNeedsStyleRecalc(LocalStyleChange);
+        setNeedsStyleRecalc(StyleChangeReasonForTracing::Attribute, LocalStyleChange);

[esprehn, 2014/09/19 04:53:09]

Shouldn't we pass along the name of the attribute too?

[kouhei (in TOK), 2014/09/22 09:03:54]

Done.

     }
 
     if (isIdAttributeName(name)) {
@@ -980,7 +980,7 @@ void Element::attributeChanged(const QualifiedName& name, const AtomicString& ne
 
     // If there is currently no StyleResolver, we can't be sure that this attribute change won't affect style.
     if (!styleResolver)
-        setNeedsStyleRecalc(SubtreeStyleChange);
+        setNeedsStyleRecalc(StyleChangeReasonForTracing::Attribute, SubtreeStyleChange);
 
     if (AXObjectCache* cache = document().existingAXObjectCache())
         cache->handleAttributeChanged(name, this);
@@ -1606,7 +1606,7 @@ ElementShadow& Element::ensureShadow()
 
 void Element::didAffectSelector(AffectedSelectorMask mask)
 {
-    setNeedsStyleRecalc(SubtreeStyleChange);
+    setNeedsStyleRecalc(StyleChangeReasonForTracing::Selector, SubtreeStyleChange);

[esprehn, 2014/09/19 04:53:09]

which selector?

[kouhei (in TOK), 2014/09/22 09:03:54]

Done.

     if (ElementShadow* elementShadow = shadowWhereNodeCanBeDistributed(*this))
         elementShadow->didAffectSelector(mask);
 }
@@ -1624,7 +1624,7 @@ void Element::setNeedsAnimationStyleRecalc()
     if (styleChangeType() != NoStyleChange)
         return;
 
-    setNeedsStyleRecalc(LocalStyleChange);
+    setNeedsStyleRecalc(StyleChangeReasonForTracing::Animation, LocalStyleChange);
     setAnimationStyleChange(true);
 }
 
@@ -1726,7 +1726,7 @@ void Element::checkForEmptyStyleChange()
         return;
 
     if (!style || (styleAffectedByEmpty() && (!style->emptyState() || hasChildren())))
-        setNeedsStyleRecalc(SubtreeStyleChange);
+        setNeedsStyleRecalc(StyleChangeReasonForTracing::EmptyPseudoClass, SubtreeStyleChange);
 }
 
 void Element::childrenChanged(const ChildrenChange& change)
@@ -2644,7 +2644,7 @@ void Element::setFloatingPointAttribute(const QualifiedName& attributeName, doub
 void Element::setContainsFullScreenElement(bool flag)
 {
     setElementFlag(ContainsFullScreenElement, flag);
-    setNeedsStyleRecalc(SubtreeStyleChange);
+    setNeedsStyleRecalc(StyleChangeReasonForTracing::FullScreen, SubtreeStyleChange);
 }
 
 static Element* parentCrossingFrameBoundaries(Element* element)
@@ -3109,14 +3109,14 @@ void Element::styleAttributeChanged(const AtomicString& newStyleString, Attribut
 
     elementData()->m_styleAttributeIsDirty = false;
 
-    setNeedsStyleRecalc(LocalStyleChange);
+    setNeedsStyleRecalc(StyleChangeReasonForTracing::StyleSheetChange, LocalStyleChange);
     InspectorInstrumentation::didInvalidateStyleAttr(this);
 }
 
 void Element::inlineStyleChanged()
 {
     ASSERT(isStyledElement());
-    setNeedsStyleRecalc(LocalStyleChange);
+    setNeedsStyleRecalc(StyleChangeReasonForTracing::Inline, LocalStyleChange);
     ASSERT(elementData());
     elementData()->m_styleAttributeIsDirty = true;
     InspectorInstrumentation::didInvalidateStyleAttr(this);