Source/core/html/HTMLTextAreaElement.cpp - Issue 547823002: Track reasons for |Node::SetNeedsStyleRecalc|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTextAreaElement.cpp

Issue 547823002: Track reasons for |Node::SetNeedsStyleRecalc| (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: use AtomicString Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLTextAreaElement.cpp

diff --git a/Source/core/html/HTMLTextAreaElement.cpp b/Source/core/html/HTMLTextAreaElement.cpp

index e1b1bd215411de5bff82792ddda1c63ffe416b1e..bd11c103d89d92ec18bcf450aae93ad93c8c8a9d 100644

--- a/Source/core/html/HTMLTextAreaElement.cpp

+++ b/Source/core/html/HTMLTextAreaElement.cpp

@@ -381,7 +381,7 @@ void HTMLTextAreaElement::setValueCommon(const String& newValue, TextFieldEventB

if (eventBehavior == DispatchNoEvent)

setLastChangeWasNotUserEdit();

updatePlaceholderVisibility(false);

- setNeedsStyleRecalc(SubtreeStyleChange);

+ setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::ControlValue));

m_suggestedValue = String();

setNeedsValidityCheck();

if (isFinishedParsingChildren()) {

@@ -473,7 +473,7 @@ void HTMLTextAreaElement::setSuggestedValue(const String& value)

else

setInnerEditorValue(m_value);

updatePlaceholderVisibility(false);

- setNeedsStyleRecalc(SubtreeStyleChange);

+ setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::ControlValue));

}

String HTMLTextAreaElement::validationMessage() const