Track reasons for |Node::SetNeedsStyleRecalc|

Source/core/css/invalidation/StyleInvalidator.cpp

 
 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 
 #include "core/css/invalidation/StyleInvalidator.h"
 
 #include "core/css/invalidation/DescendantInvalidationSet.h"
@@ skipping 127 matching lines @@
 {
     RecursionCheckpoint checkpoint(&recursionData);
 
     bool thisElementNeedsStyleRecalc = checkInvalidationSetsAgainstElement(element, recursionData);
 
     bool someChildrenNeedStyleRecalc = false;
     if (recursionData.hasInvalidationSets() || element.childNeedsStyleInvalidation())
         someChildrenNeedStyleRecalc = invalidateChildren(element, recursionData);
 
     if (thisElementNeedsStyleRecalc) {
-        element.setNeedsStyleRecalc(recursionData.wholeSubtreeInvalid() ? SubtreeStyleChange : LocalStyleChange);
+        element.setNeedsStyleRecalc(StyleChangeReasonForTracing::StyleInvalidator, recursionData.wholeSubtreeInvalid() ? SubtreeStyleChange : LocalStyleChange);

[esprehn, 2014/09/19 04:53:09]

I'm not sure this is really adding value for developers. StyleInvalidator could
be class, id, pseudo or any number of other changes.

[kouhei (in TOK), 2014/09/22 09:03:54]

This is to be addressed in next CL. I’m adding TraceEvents in StyleInvalidator
and setNeedsStyleInvalidation too. When the devtools post processing finds this
TraceEvent, it will search for matching StyleInvalidator TraceEvent with the
class/id/pseudo/attr info.

     } else if (recursionData.hasInvalidationSets() && someChildrenNeedStyleRecalc) {
         // Clone the RenderStyle in order to preserve correct style sharing, if possible. Otherwise recalc style.
         if (RenderObject* renderer = element.renderer())
             renderer->setStyleInternal(RenderStyle::clone(renderer->style()));
         else
-            element.setNeedsStyleRecalc(LocalStyleChange);
+            element.setNeedsStyleRecalc(StyleChangeReasonForTracing::StyleInvalidator, LocalStyleChange);
     }
 
     element.clearChildNeedsStyleInvalidation();
     element.clearNeedsStyleInvalidation();
 
     return thisElementNeedsStyleRecalc;
 }
 
 void StyleInvalidator::trace(Visitor* visitor)
 {
 #if ENABLE(OILPAN)
     visitor->trace(m_pendingInvalidationMap);
 #endif
 }
 
 } // namespace blink