Track reasons for |Node::SetNeedsStyleRecalc|

Source/core/html/HTMLObjectElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Stefan Schimanski (1Stein@gmx.de)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 239 matching lines @@
     } else if (name == dataAttr) {
         needsInvalidation = !fastHasAttribute(classidAttr);
     } else if (name == classidAttr) {
         needsInvalidation = true;
     } else {
         ASSERT_NOT_REACHED();
         needsInvalidation = false;
     }
     setNeedsWidgetUpdate(true);
     if (needsInvalidation)
-        setNeedsStyleRecalc(SubtreeStyleChange);
+        setNeedsStyleRecalc(StyleRecalcDueToPlugin, SubtreeStyleChange);

[rune, 2014/09/08 08:33:24]

This SubtreeStyleChange is a hack to trigger a re-attach from
HTMLPlugInElement::willRecalcStyle. There is no style recalc needed as such.
See: https://codereview.chromium.org/521603002/

 }
 
 // FIXME: This should be unified with HTMLEmbedElement::updateWidget and
 // moved down into HTMLPluginElement.cpp
 void HTMLObjectElement::updateWidgetInternal()
 {
     ASSERT(!renderEmbeddedObject()->showsUnavailablePluginIndicator());
     ASSERT(needsWidgetUpdate());
     setNeedsWidgetUpdate(false);
     // FIXME: This should ASSERT isFinishedParsingChildren() instead.
@@ skipping 54 matching lines @@
 void HTMLObjectElement::removedFrom(ContainerNode* insertionPoint)
 {
     HTMLPlugInElement::removedFrom(insertionPoint);
     FormAssociatedElement::removedFrom(insertionPoint);
 }
 
 void HTMLObjectElement::childrenChanged(const ChildrenChange& change)
 {
     if (inDocument() && !useFallbackContent()) {
         setNeedsWidgetUpdate(true);
-        setNeedsStyleRecalc(SubtreeStyleChange);
+        setNeedsStyleRecalc(StyleRecalcDueToPlugin, SubtreeStyleChange);
     }
     HTMLPlugInElement::childrenChanged(change);
 }
 
 bool HTMLObjectElement::isURLAttribute(const Attribute& attribute) const
 {
     return attribute.name() == codebaseAttr || attribute.name() == dataAttr
         || (attribute.name() == usemapAttr && attribute.value().string()[0] != '#')
         || HTMLPlugInElement::isURLAttribute(attribute);
 }
@@ skipping 112 matching lines @@
 {
     return fastHasAttribute(usemapAttr);
 }
 
 bool HTMLObjectElement::useFallbackContent() const
 {
     return HTMLPlugInElement::useFallbackContent() || m_useFallbackContent;
 }
 
 }