Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 547793002: Add lots of testonly annotations to the GN build. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, zea+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, sievers+watch_chromium.org, ben+aura_chromium.org, ben+mojo_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, jam, abarth-chromium, jbauman+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, haitaol+watch_chromium.org, danakj+watch_chromium.org, kalyank, piman+watch_chromium.org, darin (slow to review), jochen+watch_chromium.org, maniscalco+watch_chromium.org, Ian Vollick, tfarina, Aaron Boodman, cc-bugs_chromium.org, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/8f80ad0b602647f3dd40b88866c19bbd3a67915a Cr-Commit-Position: refs/heads/master@{#293774}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : dbus #

Patch Set 4 : net #

Patch Set 5 : merge #

Patch Set 6 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M ash/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M base/test/BUILD.gn View 1 3 chunks +3 lines, -0 lines 0 comments Download
M cc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/data_reduction_proxy/browser/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M components/proximity_auth/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M content/test/BUILD.gn View 5 2 chunks +2 lines, -0 lines 0 comments Download
M dbus/BUILD.gn View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M extensions/BUILD.gn View 5 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gcm/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M jingle/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/BUILD.gn View 1 4 chunks +4 lines, -0 lines 0 comments Download
M mojo/common/test/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M mojo/embedder/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/BUILD.gn View 1 2 3 4 14 chunks +14 lines, -0 lines 0 comments Download
M ppapi/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M rlz/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sync/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M ui/aura/BUILD.gn View 5 3 chunks +5 lines, -0 lines 0 comments Download
M ui/compositor/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/message_center/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/webview/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/wm/BUILD.gn View 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
brettw
6 years, 3 months ago (2014-09-05 22:25:37 UTC) #2
Alpha Left Google
On 2014/09/05 22:25:37, brettw wrote: LGTM.
6 years, 3 months ago (2014-09-08 18:18:43 UTC) #3
brettw
Committed patchset #6 (id:100001) to pending queue manually as dccea85.
6 years, 3 months ago (2014-09-08 20:12:00 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:47:48 UTC) #5
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/8f80ad0b602647f3dd40b88866c19bbd3a67915a
Cr-Commit-Position: refs/heads/master@{#293774}

Powered by Google App Engine
This is Rietveld 408576698