Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 547763003: Revert of Revert of Use SkSurface and SkImage instead of SkGpuDevice and SkBitmap in cc. (Closed)

Created:
6 years, 3 months ago by arv (Not doing code reviews)
Modified:
6 years, 3 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Use SkSurface and SkImage instead of SkGpuDevice and SkBitmap in cc. (patchset #1 id:1 of https://codereview.chromium.org/546073002/) Reason for revert: This revert did not fix the pixel tests Original issue's description: > Revert of Use SkSurface and SkImage instead of SkGpuDevice and SkBitmap in cc. (patchset #5 id:80001 of https://codereview.chromium.org/520793002/) > > Reason for revert: > Looks like it may have broken the layout tests. > > http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7/builds/31264 > > Original issue's description: > > Use SkSurface and SkImage instead of SkGpuDevice and SkBitmap in cc. > > > > Committed: https://chromium.googlesource.com/chromium/src/+/37ffe8f81510bbfb82b48640aa96fe7e51efc654 > > TBR=enne@chromium.org,senorblanco@chromium.org,sugoi@chromium.org,danakj@chromium.org > NOTREECHECKS=true > NOTRY=true > > Committed: https://chromium.googlesource.com/chromium/src/+/cea33af6d0b2c2c1805ef016da5161fc0ed540a0 TBR=enne@chromium.org,senorblanco@chromium.org,sugoi@chromium.org,danakj@chromium.org,robertphillips@google.com,reveman@chromium.org,bsalomon@google.com NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a4ef99209824054b6b627e6f26ab0a115249856e Cr-Commit-Position: refs/heads/master@{#293587}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -49 lines) Patch
M cc/output/gl_renderer.cc View 11 chunks +56 lines, -48 lines 0 comments Download
M cc/resources/resource_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
arv (Not doing code reviews)
Created Revert of Revert of Use SkSurface and SkImage instead of SkGpuDevice and SkBitmap in ...
6 years, 3 months ago (2014-09-05 22:47:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/547763003/1
6 years, 3 months ago (2014-09-05 22:47:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3182165e4b2c054136e4cc9d3c48e00f132af796
6 years, 3 months ago (2014-09-05 22:50:21 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:41:44 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4ef99209824054b6b627e6f26ab0a115249856e
Cr-Commit-Position: refs/heads/master@{#293587}

Powered by Google App Engine
This is Rietveld 408576698