Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
547753004:
Allow the content setting or resource type to be passed into the Website Settings page by a hash. (Closed)
|
Created:
6 years, 3 months ago by Daniel Nishi Modified:
6 years, 3 months ago Reviewers:
Bernhard Bauer CC:
scheib, chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Project:
chromium Visibility:
Public. |
DescriptionAllow the content setting or resource type to be passed into the Website Settings page by a hash.
Committed: https://crrev.com/f0b87308740ec0e6f251688e7e0aa4e1f65c4ab0
Cr-Commit-Position: refs/heads/master@{#294189}
Patch Set 1 #
Total comments: 2
Patch Set 2 : No longer iterating through the entire list. #Patch Set 3 : Fix a bug where the page could get updated before it was initialized. #Messages
Total messages: 21 (8 generated)
dhnishi@chromium.org changed reviewers: + bauerb@chromium.org
bauerb: PTAL when you get a chance. This is in prep for (Google internal mock) https://docs.google.com/a/google.com/uc?id=0B-Vmdj5n-YddRU0wNWFweDIyUTg being able to select the permission from a layer up from the Website Settings options page.
https://codereview.chromium.org/547753004/diff/1/chrome/browser/resources/opt... File chrome/browser/resources/options/website_settings.js (right): https://codereview.chromium.org/547753004/diff/1/chrome/browser/resources/opt... chrome/browser/resources/options/website_settings.js:73: for (var i = 0; i < selectResource.options.length; i++) { I think there's an easier way to do this... can you assign selectResource.value directly?
https://codereview.chromium.org/547753004/diff/1/chrome/browser/resources/opt... File chrome/browser/resources/options/website_settings.js (right): https://codereview.chromium.org/547753004/diff/1/chrome/browser/resources/opt... chrome/browser/resources/options/website_settings.js:73: for (var i = 0; i < selectResource.options.length; i++) { On 2014/09/09 09:05:22, Bernhard Bauer wrote: > I think there's an easier way to do this... can you assign selectResource.value > directly? Huh. I thought I tested that and it didn't work, but it works. Done.
lgtm
The CQ bit was checked by dhnishi@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dhnishi@chromium.org/547753004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by dhnishi@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dhnishi@chromium.org/547753004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by dhnishi@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dhnishi@chromium.org/547753004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by dhnishi@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dhnishi@chromium.org/547753004/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as fa5ddd11655caa9a69f3f3cda6ee6a03d5926934
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/f0b87308740ec0e6f251688e7e0aa4e1f65c4ab0 Cr-Commit-Position: refs/heads/master@{#294189} |
