Chromium Code Reviews

Issue 547743003: Revert of Revert of Service Worker: Add tests for same-scope new script registration (Closed)

Created:
6 years, 3 months ago by horo
Modified:
6 years, 3 months ago
Reviewers:
michaeln, falken, nhiroki, mlamouri (slow - plz ping)
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Project:
blink
Visibility:
Public.

Description

Revert of Revert of Service Worker: Add tests for same-scope new script registration (patchset #1 id:1 of https://codereview.chromium.org/512703002/) Reason for revert: This crash will be fixed by https://codereview.chromium.org/556003006. Original issue's description: > Revert of Service Worker: Add tests for same-scope new script registration (patchset #6 of https://codereview.chromium.org/480943002/) > > Reason for revert: > This is crashing on Mac. > > Original issue's description: > > Service Worker: Add tests for same-scope, new script registration > > > > Tests for Chromium patch: > > https://codereview.chromium.org/506043002/ > > > > BUG=398355 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180948 > > TBR=michaeln@chromium.org,nhiroki@chromium.org,falken@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=398355 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180956 TBR=michaeln@chromium.org,nhiroki@chromium.org,falken@chromium.org,mlamouri@chromium.org NOTREECHECKS=true NOTRY=true BUG=398355 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181878

Patch Set 1 #

Patch Set 2 : rebase and change the SW scope in unregister-then-register-new-script.html #

Total comments: 4

Patch Set 3 : incorporated michaeln's comment #

Unified diffs Side-by-side diffs Stats (+364 lines, -32 lines)
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments
A LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html View 1 chunk +254 lines, -0 lines 0 comments
M LayoutTests/http/tests/serviceworker/resources/test-helpers.js View 1 chunk +18 lines, -8 lines 0 comments
M LayoutTests/http/tests/serviceworker/unregister-then-register-new-script.html View 6 chunks +92 lines, -23 lines 0 comments

Messages

Total messages: 8 (3 generated)
horo
Created Revert of Revert of Service Worker: Add tests for same-scope new script registration
6 years, 3 months ago (2014-09-11 12:16:16 UTC) #1
michaeln
lgtm https://codereview.chromium.org/547743003/diff/170001/LayoutTests/http/tests/serviceworker/resources/test-helpers.js File LayoutTests/http/tests/serviceworker/resources/test-helpers.js (right): https://codereview.chromium.org/547743003/diff/170001/LayoutTests/http/tests/serviceworker/resources/test-helpers.js#newcode71 LayoutTests/http/tests/serviceworker/resources/test-helpers.js:71: 'wait_for_update must be passed a ServiceWorkerRegistration')); ditto https://codereview.chromium.org/547743003/diff/170001/LayoutTests/http/tests/serviceworker/resources/test-helpers.js#newcode84 ...
6 years, 3 months ago (2014-09-12 00:37:20 UTC) #4
horo
https://codereview.chromium.org/547743003/diff/170001/LayoutTests/http/tests/serviceworker/resources/test-helpers.js File LayoutTests/http/tests/serviceworker/resources/test-helpers.js (right): https://codereview.chromium.org/547743003/diff/170001/LayoutTests/http/tests/serviceworker/resources/test-helpers.js#newcode71 LayoutTests/http/tests/serviceworker/resources/test-helpers.js:71: 'wait_for_update must be passed a ServiceWorkerRegistration')); On 2014/09/12 00:37:20, ...
6 years, 3 months ago (2014-09-12 01:16:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/547743003/190001
6 years, 3 months ago (2014-09-12 05:22:23 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 05:23:01 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:190001) as 181878

Powered by Google App Engine