Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: tools/bisect-builds.py

Issue 547733003: bisect-builds.py: Add another search pattern to get SVN revision number from git hash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bisect-builds.py
diff --git a/tools/bisect-builds.py b/tools/bisect-builds.py
index eb7e6d73398b90e0807e7f49abb3f7338d8bedc3..09b5804d2697e3f7daf32a0c9d59b1d7fceeecf1 100755
--- a/tools/bisect-builds.py
+++ b/tools/bisect-builds.py
@@ -67,6 +67,8 @@ GITHASH_TO_SVN_URL = {
# CHROMIUM_GITHASH_TO_SVN_URL to get the chromium revision (svn revision).
CHROMIUM_SEARCH_PATTERN = (
r'.*git-svn-id: svn://svn.chromium.org/chrome/trunk/src@(\d+) ')
+CHROMIUM_SEARCH_PATTERN_NEW = (
+ r'Cr-Commit-Position: refs/heads/master@{#(\d+)}')
# Search pattern to be matched in the json output from
# BLINK_GITHASH_TO_SVN_URL to get the blink revision (svn revision).
@@ -338,6 +340,12 @@ class PathContext(object):
result = search_pattern.search(message[len(message)-1])
if result:
return result.group(1)
+ else:
+ if depot == 'chromium':
+ result = re.search(CHROMIUM_SEARCH_PATTERN_NEW,
+ message[len(message)-1])
+ if result:
+ return result.group(1)
print 'Failed to get svn revision number for %s' % git_sha1
raise ValueError
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698