Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 547733003: bisect-builds.py: Add another search pattern to get SVN revision number from git hash. (Closed)

Created:
6 years, 3 months ago by pshenoy
Modified:
6 years, 3 months ago
CC:
chromium-reviews, anantha
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

bisect-builds.py: Add another search pattern to get SVN revision number from git hash. Recently string containing the SVN revision has changed. This change handles both. Examples below. Old: https://chromium.googlesource.com/chromium/src/+/01188669a2b154818e5db03cc36fb2dd23b8d947 New: https://chromium.googlesource.com/chromium/src/+/13cb79e07dcf1138a35a82e312aea265b06e8879 BUG=None NOTRY=True Committed: https://crrev.com/b23a1457553842aa570bfefbe858c963f4e569db Cr-Commit-Position: refs/heads/master@{#293588}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M tools/bisect-builds.py View 1 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
pshenoy
6 years, 3 months ago (2014-09-05 20:31:24 UTC) #2
DaleCurtis
lgtm https://codereview.chromium.org/547733003/diff/1/tools/bisect-builds.py File tools/bisect-builds.py (right): https://codereview.chromium.org/547733003/diff/1/tools/bisect-builds.py#newcode339 tools/bisect-builds.py:339: search_pattern = re.compile(SEARCH_PATTERN[depot]) Should you flip the order ...
6 years, 3 months ago (2014-09-05 21:51:30 UTC) #3
pshenoy
https://codereview.chromium.org/547733003/diff/1/tools/bisect-builds.py File tools/bisect-builds.py (right): https://codereview.chromium.org/547733003/diff/1/tools/bisect-builds.py#newcode339 tools/bisect-builds.py:339: search_pattern = re.compile(SEARCH_PATTERN[depot]) On 2014/09/05 21:51:30, DaleCurtis wrote: > ...
6 years, 3 months ago (2014-09-05 22:25:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pshenoy@chromium.org/547733003/20001
6 years, 3 months ago (2014-09-05 22:50:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as a78e20aaf2ab272f62fc238a1fabbf683b2277cc
6 years, 3 months ago (2014-09-05 22:54:03 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:41:46 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b23a1457553842aa570bfefbe858c963f4e569db
Cr-Commit-Position: refs/heads/master@{#293588}

Powered by Google App Engine
This is Rietveld 408576698