ppapi/proxy/ppb_graphics_3d_proxy.h - Issue 547733002: [Pepper GL] Use shared state to fix a memory leak in MapSub GL extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/ppb_graphics_3d_proxy.h

Issue 547733002: [Pepper GL] Use shared state to fix a memory leak in MapSub GL extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remve base/memory/shared_memory.h from DEPS Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/proxy/ppb_graphics_3d_proxy.h

diff --git a/ppapi/proxy/ppb_graphics_3d_proxy.h b/ppapi/proxy/ppb_graphics_3d_proxy.h

index 0a0a7484a449310a23f154af65bdf5abf49c9c53..610c3875772c4f341c71b13b2f785e0bae3155f8 100644

--- a/ppapi/proxy/ppb_graphics_3d_proxy.h

+++ b/ppapi/proxy/ppb_graphics_3d_proxy.h

@@ -32,7 +32,8 @@ class PPAPI_PROXY_EXPORT Graphics3D : public PPB_Graphics3D_Shared {

explicit Graphics3D(const HostResource& resource);

virtual ~Graphics3D();

- bool Init(gpu::gles2::GLES2Implementation* share_gles2);

+ bool Init(gpu::gles2::GLES2Implementation* share_gles2,

+ const SerializedHandle& shared_state);

// Graphics3DTrusted API. These are not implemented in the proxy.

virtual PP_Bool SetGetBuffer(int32_t shm_id) OVERRIDE;

@@ -79,7 +80,8 @@ class PPB_Graphics3D_Proxy : public InterfaceProxy {

void OnMsgCreate(PP_Instance instance,

HostResource share_context,

const std::vector<int32_t>& attribs,

- HostResource* result);

+ HostResource* result,

+ SerializedHandle* handle);

void OnMsgSetGetBuffer(const HostResource& context,

int32 id);

void OnMsgWaitForTokenInRange(const HostResource& context,

« no previous file with comments | « ppapi/proxy/ppapi_messages.h ('k') | ppapi/proxy/ppb_graphics_3d_proxy.cc » ('j') | no next file with comments »