Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

Issue 547703004: Some JS cleanup, including proper ownership of ONC properties. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_279351_internet_options_8b
Patch Set: Rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options/chromeos/internet_options_handler.h" 5 #include "chrome/browser/ui/webui/options/chromeos/internet_options_handler.h"
6 6
7 #include <ctype.h> 7 #include <ctype.h>
8 8
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 const char kSetDefaultNetworkIconsFunction[] = 83 const char kSetDefaultNetworkIconsFunction[] =
84 "options.network.NetworkList.setDefaultNetworkIcons"; 84 "options.network.NetworkList.setDefaultNetworkIcons";
85 const char kShowDetailedInfoFunction[] = 85 const char kShowDetailedInfoFunction[] =
86 "options.internet.DetailsInternetPage.showDetailedInfo"; 86 "options.internet.DetailsInternetPage.showDetailedInfo";
87 const char kUpdateConnectionDataFunction[] = 87 const char kUpdateConnectionDataFunction[] =
88 "options.internet.DetailsInternetPage.updateConnectionData"; 88 "options.internet.DetailsInternetPage.updateConnectionData";
89 const char kUpdateCarrierFunction[] = 89 const char kUpdateCarrierFunction[] =
90 "options.internet.DetailsInternetPage.updateCarrier"; 90 "options.internet.DetailsInternetPage.updateCarrier";
91 91
92 // These are used to register message handlers with JavaScript. 92 // These are used to register message handlers with JavaScript.
93 const char kBuyDataPlanMessage[] = "buyDataPlan";
94 const char kChangePinMessage[] = "changePin"; 93 const char kChangePinMessage[] = "changePin";
95 const char kDisableCellularMessage[] = "disableCellular"; 94 const char kDisableCellularMessage[] = "disableCellular";
96 const char kDisableWifiMessage[] = "disableWifi"; 95 const char kDisableWifiMessage[] = "disableWifi";
97 const char kDisableWimaxMessage[] = "disableWimax"; 96 const char kDisableWimaxMessage[] = "disableWimax";
98 const char kEnableCellularMessage[] = "enableCellular"; 97 const char kEnableCellularMessage[] = "enableCellular";
99 const char kEnableWifiMessage[] = "enableWifi"; 98 const char kEnableWifiMessage[] = "enableWifi";
100 const char kEnableWimaxMessage[] = "enableWimax"; 99 const char kEnableWimaxMessage[] = "enableWimax";
101 const char kNetworkCommandMessage[] = "networkCommand"; 100 const char kNetworkCommandMessage[] = "networkCommand";
102 const char kRefreshNetworksMessage[] = "refreshNetworks"; 101 const char kRefreshNetworksMessage[] = "refreshNetworks";
103 const char kSetApnMessage[] = "setApn"; 102 const char kSetApnMessage[] = "setApn";
(...skipping 348 matching lines...) Expand 10 before | Expand all | Expand 10 after
452 base::Unretained(this))); 451 base::Unretained(this)));
453 web_ui()->RegisterMessageCallback(kDisableCellularMessage, 452 web_ui()->RegisterMessageCallback(kDisableCellularMessage,
454 base::Bind(&InternetOptionsHandler::DisableCellularCallback, 453 base::Bind(&InternetOptionsHandler::DisableCellularCallback,
455 base::Unretained(this))); 454 base::Unretained(this)));
456 web_ui()->RegisterMessageCallback(kEnableWimaxMessage, 455 web_ui()->RegisterMessageCallback(kEnableWimaxMessage,
457 base::Bind(&InternetOptionsHandler::EnableWimaxCallback, 456 base::Bind(&InternetOptionsHandler::EnableWimaxCallback,
458 base::Unretained(this))); 457 base::Unretained(this)));
459 web_ui()->RegisterMessageCallback(kDisableWimaxMessage, 458 web_ui()->RegisterMessageCallback(kDisableWimaxMessage,
460 base::Bind(&InternetOptionsHandler::DisableWimaxCallback, 459 base::Bind(&InternetOptionsHandler::DisableWimaxCallback,
461 base::Unretained(this))); 460 base::Unretained(this)));
462 web_ui()->RegisterMessageCallback(kBuyDataPlanMessage,
463 base::Bind(&InternetOptionsHandler::BuyDataPlanCallback,
464 base::Unretained(this)));
465 web_ui()->RegisterMessageCallback(kShowMorePlanInfoMessage, 461 web_ui()->RegisterMessageCallback(kShowMorePlanInfoMessage,
466 base::Bind(&InternetOptionsHandler::ShowMorePlanInfoCallback, 462 base::Bind(&InternetOptionsHandler::ShowMorePlanInfoCallback,
467 base::Unretained(this))); 463 base::Unretained(this)));
468 web_ui()->RegisterMessageCallback(kSetApnMessage, 464 web_ui()->RegisterMessageCallback(kSetApnMessage,
469 base::Bind(&InternetOptionsHandler::SetApnCallback, 465 base::Bind(&InternetOptionsHandler::SetApnCallback,
470 base::Unretained(this))); 466 base::Unretained(this)));
471 web_ui()->RegisterMessageCallback(kSetCarrierMessage, 467 web_ui()->RegisterMessageCallback(kSetCarrierMessage,
472 base::Bind(&InternetOptionsHandler::SetCarrierCallback, 468 base::Bind(&InternetOptionsHandler::SetCarrierCallback,
473 base::Unretained(this))); 469 base::Unretained(this)));
474 web_ui()->RegisterMessageCallback(kSetSimCardLockMessage, 470 web_ui()->RegisterMessageCallback(kSetSimCardLockMessage,
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
547 if (!web_ui()) 543 if (!web_ui())
548 return; 544 return;
549 std::string service_path; 545 std::string service_path;
550 if (args->GetSize() != 1 || !args->GetString(0, &service_path)) { 546 if (args->GetSize() != 1 || !args->GetString(0, &service_path)) {
551 NOTREACHED(); 547 NOTREACHED();
552 return; 548 return;
553 } 549 }
554 ash::network_connect::ShowMobileSetup(service_path); 550 ash::network_connect::ShowMobileSetup(service_path);
555 } 551 }
556 552
557 void InternetOptionsHandler::BuyDataPlanCallback(const base::ListValue* args) {
558 if (!web_ui())
559 return;
560 std::string service_path;
561 if (args->GetSize() != 1 || !args->GetString(0, &service_path)) {
562 NOTREACHED();
563 return;
564 }
565 ash::network_connect::ShowMobileSetup(service_path);
566 }
567
568 void InternetOptionsHandler::SetApnCallback(const base::ListValue* args) { 553 void InternetOptionsHandler::SetApnCallback(const base::ListValue* args) {
569 std::string service_path; 554 std::string service_path;
570 if (!args->GetString(0, &service_path)) { 555 if (!args->GetString(0, &service_path)) {
571 NOTREACHED(); 556 NOTREACHED();
572 return; 557 return;
573 } 558 }
574 NetworkHandler::Get()->network_configuration_handler()->GetProperties( 559 NetworkHandler::Get()->network_configuration_handler()->GetProperties(
575 service_path, 560 service_path,
576 base::Bind(&InternetOptionsHandler::SetApnProperties, 561 base::Bind(&InternetOptionsHandler::SetApnProperties,
577 weak_factory_.GetWeakPtr(), base::Owned(args->DeepCopy())), 562 weak_factory_.GetWeakPtr(), base::Owned(args->DeepCopy())),
(...skipping 579 matching lines...) Expand 10 before | Expand all | Expand 10 after
1157 dictionary->SetBoolean( 1142 dictionary->SetBoolean(
1158 kTagWimaxAvailable, 1143 kTagWimaxAvailable,
1159 handler->IsTechnologyAvailable(NetworkTypePattern::Wimax())); 1144 handler->IsTechnologyAvailable(NetworkTypePattern::Wimax()));
1160 dictionary->SetBoolean( 1145 dictionary->SetBoolean(
1161 kTagWimaxEnabled, 1146 kTagWimaxEnabled,
1162 handler->IsTechnologyEnabled(NetworkTypePattern::Wimax())); 1147 handler->IsTechnologyEnabled(NetworkTypePattern::Wimax()));
1163 } 1148 }
1164 1149
1165 } // namespace options 1150 } // namespace options
1166 } // namespace chromeos 1151 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698