Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 547693002: Fix the number of buckets in Net.Wifi.InterfaceCount UMA histogram. (Closed)

Created:
6 years, 3 months ago by timvolodine
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix the number of buckets in Net.Wifi.InterfaceCount UMA histogram. The number of buckets should be one more than currently specified. Otherwise the histogram buckets the values 3 and 4 in the same bucket. BUG= Committed: https://crrev.com/195037f04dc4627ca7aaf523ad035522e01ab7ae Cr-Commit-Position: refs/heads/master@{#294808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/geolocation/wifi_data_provider_corewlan_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/wifi_data_provider_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
timvolodine
6 years, 3 months ago (2014-09-08 15:25:22 UTC) #2
Michael van Ouwerkerk
lgtm Looks like this is not even instrumented on linux :-(
6 years, 3 months ago (2014-09-09 15:04:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/547693002/1
6 years, 3 months ago (2014-09-15 12:00:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as e8038643c0a1e013669f59428fdfa8db31fa865b
6 years, 3 months ago (2014-09-15 12:57:35 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 13:02:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/195037f04dc4627ca7aaf523ad035522e01ab7ae
Cr-Commit-Position: refs/heads/master@{#294808}

Powered by Google App Engine
This is Rietveld 408576698