Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 547673003: Don't use SetShape() to round the Findbar views widget corners. (Closed)

Created:
6 years, 3 months ago by Wez
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, dcheng, oshima
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't use SetShape() to round the Findbar views widget corners. Now that views widgets can be rendered with transparency there is no need to shape the widget for the visual effect, and the impact on hit- testing is negligible, so there's really no point shaping the widget. BUG=408728 Committed: https://crrev.com/e41575ab799625f286b77ae2f9f7e5a1534854c5 Cr-Commit-Position: refs/heads/master@{#294282}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -127 lines) Patch
M chrome/browser/ui/views/dropdown_bar_host.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/dropdown_bar_host.cc View 2 chunks +0 lines, -113 lines 0 comments Download
M chrome/browser/ui/views/find_bar_host.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Wez
PTAL
6 years, 3 months ago (2014-09-05 23:11:24 UTC) #2
Wez
On 2014/09/05 23:11:24, Wez wrote: > PTAL Pingy.
6 years, 3 months ago (2014-09-10 23:14:24 UTC) #3
sky
LGTM
6 years, 3 months ago (2014-09-10 23:40:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/547673003/1
6 years, 3 months ago (2014-09-11 00:04:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as ecb24ad562a62fa0df4550423cee6ea67d442947
6 years, 3 months ago (2014-09-11 01:16:28 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 01:18:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e41575ab799625f286b77ae2f9f7e5a1534854c5
Cr-Commit-Position: refs/heads/master@{#294282}

Powered by Google App Engine
This is Rietveld 408576698