Never open guest pre-NewAvatarMenu

Never open guest pre-NewAvatarMenu

BUG=410228
Committed: https://crrev.com/6b30e882803f34879eaf0b17f7d15bb8b3cfddb1
Cr-Commit-Position: refs/heads/master@{#293929}

[Mike Lerman, 2014-09-05 15:37:53]

mlerman@chromium.org changed reviewers:
+ jochen@chromium.org

[Mike Lerman, 2014-09-05 15:37:54]

Hello,

Can I get a review of this CL? Thanks!

Mike

[jochen (gone - plz use gerrit), 2014-09-08 12:14:21]

https://codereview.chromium.org/547663002/diff/1/chrome/browser/chrome_browse...
File chrome/browser/chrome_browser_main.cc (right):

https://codereview.chromium.org/547663002/diff/1/chrome/browser/chrome_browse...
chrome/browser/chrome_browser_main.cc:350: GetPathOfProfileAtIndex(0);
is zero the default profile? Should maybe be a constant on ProfileInfoCache
then? Or should this rather be the last used profile?

[Mike Lerman, 2014-09-08 14:02:33]

https://codereview.chromium.org/547663002/diff/1/chrome/browser/chrome_browse...
File chrome/browser/chrome_browser_main.cc (right):

https://codereview.chromium.org/547663002/diff/1/chrome/browser/chrome_browse...
chrome/browser/chrome_browser_main.cc:350: GetPathOfProfileAtIndex(0);
On 2014/09/08 12:14:21, jochen wrote:
> is zero the default profile? Should maybe be a constant on ProfileInfoCache
> then? Or should this rather be the last used profile?

The problem with the last used profile is the last used profile was guest...
which I can't use because the flag that introduced guest is now disabled. So I'm
essentially opening any profile I can find.

There's no concept of a "Default" profile, or anything particularly special
about the profile at index 0, except that I'm guaranteed to have a profile at
index 0.

[jochen (gone - plz use gerrit), 2014-09-08 14:14:37]

On 2014/09/08 at 14:02:33, mlerman wrote:
>
https://codereview.chromium.org/547663002/diff/1/chrome/browser/chrome_browse...
> File chrome/browser/chrome_browser_main.cc (right):
> 
>
https://codereview.chromium.org/547663002/diff/1/chrome/browser/chrome_browse...
> chrome/browser/chrome_browser_main.cc:350: GetPathOfProfileAtIndex(0);
> On 2014/09/08 12:14:21, jochen wrote:
> > is zero the default profile? Should maybe be a constant on ProfileInfoCache
> > then? Or should this rather be the last used profile?
> 
> The problem with the last used profile is the last used profile was guest...
which I can't use because the flag that introduced guest is now disabled. So I'm
essentially opening any profile I can find.
> 
> There's no concept of a "Default" profile, or anything particularly special
about the profile at index 0, except that I'm guaranteed to have a profile at
index 0.

can you please update the comment to reflect that?

[Mike Lerman, 2014-09-08 14:42:35]

On 2014/09/08 14:14:37, jochen wrote:
> On 2014/09/08 at 14:02:33, mlerman wrote:
> >
>
https://codereview.chromium.org/547663002/diff/1/chrome/browser/chrome_browse...
> > File chrome/browser/chrome_browser_main.cc (right):
> > 
> >
>
https://codereview.chromium.org/547663002/diff/1/chrome/browser/chrome_browse...
> > chrome/browser/chrome_browser_main.cc:350: GetPathOfProfileAtIndex(0);
> > On 2014/09/08 12:14:21, jochen wrote:
> > > is zero the default profile? Should maybe be a constant on
ProfileInfoCache
> > > then? Or should this rather be the last used profile?
> > 
> > The problem with the last used profile is the last used profile was guest...
> which I can't use because the flag that introduced guest is now disabled. So
I'm
> essentially opening any profile I can find.
> > 
> > There's no concept of a "Default" profile, or anything particularly special
> about the profile at index 0, except that I'm guaranteed to have a profile at
> index 0.
> 
> can you please update the comment to reflect that?

Done.

[jochen (gone - plz use gerrit), 2014-09-09 08:08:47]

lgtm

[Mike Lerman, 2014-09-09 11:23:00]

The CQ bit was checked by mlerman@chromium.org

[commit-bot: I haz the power, 2014-09-09 11:23:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlerman@chromium.org/547663002/20001

[commit-bot: I haz the power, 2014-09-09 13:14:18]

Committed patchset #2 (id:20001) as 31580bc32c98c45a18f2b3c126a6b70e27bf2f4a

[commit-bot: I haz the power, 2014-09-10 03:53:03]

Patchset 2 (id:??) landed as
https://crrev.com/6b30e882803f34879eaf0b17f7d15bb8b3cfddb1
Cr-Commit-Position: refs/heads/master@{#293929}