build/android/pylib/android_commands.py - Issue 547623002: Simpler logic to setup/restore Chrome command line

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/android_commands.py

Issue 547623002: Simpler logic to setup/restore Chrome command line (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed nit (lined up params) Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/android_commands.py

diff --git a/build/android/pylib/android_commands.py b/build/android/pylib/android_commands.py

index 7c73b526da7e35f42e32da4e7e6b8e4a7b49a62a..0a4b2f0e47348b60bffdc9a74536c980113aa9a5 100644

--- a/build/android/pylib/android_commands.py

+++ b/build/android/pylib/android_commands.py

@@ -701,8 +701,7 @@ class AndroidCommands(object):

"""Send a command to the adb shell and return the result.

Args:

- command: String containing the shell command to send. Must not include

- the single quotes as we use them to escape the whole command.

+ command: String containing the shell command to send.

timeout_time: Number of seconds to wait for command to respond before

retrying, used by AdbInterface.SendShellCommand.

log_result: Boolean to indicate whether we should log the result of the

« no previous file with comments | « no previous file | build/android/pylib/device/device_utils.py » ('j') | no next file with comments »