Add ShellAppsClient, ShellAppDelegate, ShellNativeAppWindow

extensions/shell/browser/shell_apps_client.cc

Index: extensions/shell/browser/shell_apps_client.cc
diff --git a/extensions/shell/browser/shell_apps_client.cc b/extensions/shell/browser/shell_apps_client.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d3c29036cc1ab95d6969f0b0c68e9f3facd0ae8c
--- /dev/null
+++ b/extensions/shell/browser/shell_apps_client.cc
@@ -0,0 +1,60 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "extensions/shell/browser/shell_apps_client.h"
+
+#include "extensions/browser/app_window/app_window.h"
+#include "extensions/shell/browser/desktop_controller.h"
+#include "extensions/shell/browser/shell_app_delegate.h"
+#include "extensions/shell/browser/shell_native_app_window.h"
+#include "ui/aura/window.h"
+#include "ui/aura/window_tree_host.h"
+
+namespace extensions {
+
+ShellAppsClient::ShellAppsClient() {
+}
+
+ShellAppsClient::~ShellAppsClient() {
+}
+
+std::vector<content::BrowserContext*>
+ShellAppsClient::GetLoadedBrowserContexts() {
+  NOTIMPLEMENTED();
+  return std::vector<content::BrowserContext*>();
+}
+
+AppWindow* ShellAppsClient::CreateAppWindow(content::BrowserContext* context,
+                                            const Extension* extension) {
+  return new AppWindow(context, new ShellAppDelegate, extension);
+}
+
+NativeAppWindow* ShellAppsClient::CreateNativeAppWindow(
+      AppWindow* window,
+      const AppWindow::CreateParams& params) {
+  ShellNativeAppWindow* native_app_window =
+      new ShellNativeAppWindow(window, params);
+  DesktopController::instance()->GetHost()->window()->AddChild(
+      native_app_window->GetNativeWindow());

[James Cook, 2014/09/05 16:26:42]

Do you need to call Show() on the Aura window?  The code in
ShellDesktopController::CreateAppWindow() does that.

Also, I think you should break ShellDesktopController::CreateAppWindow() into
two functions, CreateAppWindow() and AddAppWindow() to make it more clear that
there are multiple places in the code that add windows.

[hashimoto, 2014/09/05 17:37:17]

API implementation (extensions/browser/api/app_window/app_window_api.cc) is
responsible to call Show() instead.
Added AddAppWindow(), but couldn't remove the Add() part from CreateAppWindow()
because athena's implementation uses
athena::ActivityManager::Get()->AddActivity() to add the ShellAppWindow to the
hierarchy.
To get rid of Add() part from CreateAppWindow(), athena's implementation
requires AddAppWindow() to take ShellAppWindow*.
But we want to use AddAppWindow() also to add AppWindow so this doesn't work
without massively changing the code of athena or app_shell.

[James Cook, 2014/09/05 17:41:51]

OK, that makes sense.

+  return native_app_window;
+}
+
+void ShellAppsClient::IncrementKeepAliveCount() {
+  NOTIMPLEMENTED();
+}
+
+void ShellAppsClient::DecrementKeepAliveCount() {
+  NOTIMPLEMENTED();
+}
+
+void ShellAppsClient::OpenDevToolsWindow(content::WebContents* web_contents,
+                                         const base::Closure& callback) {
+  NOTIMPLEMENTED();
+}
+
+bool ShellAppsClient::IsCurrentChannelOlderThanDev() {
+  return false;
+}
+
+}  // namespace extensions