Add ShellAppsClient, ShellAppDelegate, ShellNativeAppWindow

extensions/shell/browser/shell_apps_client.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef EXTENSIONS_SHELL_BROWSER_SHELL_APPS_CLIENT_H_
+#define EXTENSIONS_SHELL_BROWSER_SHELL_APPS_CLIENT_H_
+
+#include "base/basictypes.h"

[James Cook, 2014/09/05 16:26:42]

nit: macros.h and compiler_specific.h, since you aren't actually using integer
types.

[hashimoto, 2014/09/05 17:37:17]

Done.

+#include "extensions/browser/app_window/apps_client.h"
+
+namespace extensions {
+
+class ShellAppsClient : public AppsClient {

[James Cook, 2014/09/05 16:26:42]

nit: brief class comment?

[hashimoto, 2014/09/05 17:37:17]

Done.

+ public:
+  ShellAppsClient();
+  virtual ~ShellAppsClient();
+
+  // AppsClient overrides:
+  virtual std::vector<content::BrowserContext*> GetLoadedBrowserContexts()
+      OVERRIDE;
+  virtual AppWindow* CreateAppWindow(content::BrowserContext* context,
+                                     const Extension* extension) OVERRIDE;
+  virtual NativeAppWindow* CreateNativeAppWindow(
+      AppWindow* window,
+      const AppWindow::CreateParams& params) OVERRIDE;
+  virtual void IncrementKeepAliveCount() OVERRIDE;
+  virtual void DecrementKeepAliveCount() OVERRIDE;
+  virtual void OpenDevToolsWindow(content::WebContents* web_contents,
+                                  const base::Closure& callback) OVERRIDE;
+  virtual bool IsCurrentChannelOlderThanDev() OVERRIDE;

[James Cook, 2014/09/05 16:26:43]

Not for this CL, but this seems like an odd method to have on this interface. I
would expect it to be something like "IsCurrentChannelOlderThan(const
std::string& channel)". I know the current channel constants exist only in
src/chrome, but I would be OK with introducing well known strings for "canary",
"dev", "beta", "stable" for these sorts of interfaces. Or we could push the
concept of channel into src/components.

[hashimoto, 2014/09/05 17:37:17]

Makes sense.
Filed crbug.com/411352

+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ShellAppsClient);
+};
+
+}  // namespace extensions
+
+#endif  // EXTENSIONS_SHELL_BROWSER_SHELL_APPS_CLIENT_H_