Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 547563002: [ServiceWorker] Add m_skipServiceWorker to CrossThreadResourceRequestData. (Closed)

Created:
6 years, 3 months ago by horo
Modified:
6 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Add m_skipServiceWorker to CrossThreadResourceRequestData. I added m_skipServiceWorker to ResourceRequest in https://codereview.chromium.org/527703002/. But I forgot to add it to CrossThreadResourceRequestData. BUG=402093 TEST=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181531

Patch Set 1 #

Patch Set 2 : Add test #

Total comments: 8

Patch Set 3 : incorporated tkent's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -0 lines) Patch
M Source/platform/blink_platform.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/network/ResourceRequest.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/network/ResourceRequest.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
A Source/platform/network/ResourceRequestTest.cpp View 1 2 1 chunk +104 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
horo
tkent@ Could you please review this?
6 years, 3 months ago (2014-09-05 07:01:45 UTC) #2
tkent
Can you add a test?
6 years, 3 months ago (2014-09-05 07:45:39 UTC) #3
horo
On 2014/09/05 07:45:39, tkent wrote: > Can you add a test? done.
6 years, 3 months ago (2014-09-05 10:21:14 UTC) #4
tkent
lgtm https://codereview.chromium.org/547563002/diff/20001/Source/platform/network/ResourceRequestTest.cpp File Source/platform/network/ResourceRequestTest.cpp (right): https://codereview.chromium.org/547563002/diff/20001/Source/platform/network/ResourceRequestTest.cpp#newcode13 Source/platform/network/ResourceRequestTest.cpp:13: nit: This blank line is unnecessary. https://codereview.chromium.org/547563002/diff/20001/Source/platform/network/ResourceRequestTest.cpp#newcode25 Source/platform/network/ResourceRequestTest.cpp:25: ...
6 years, 3 months ago (2014-09-07 23:53:54 UTC) #5
horo
Thank you. https://codereview.chromium.org/547563002/diff/20001/Source/platform/network/ResourceRequestTest.cpp File Source/platform/network/ResourceRequestTest.cpp (right): https://codereview.chromium.org/547563002/diff/20001/Source/platform/network/ResourceRequestTest.cpp#newcode13 Source/platform/network/ResourceRequestTest.cpp:13: On 2014/09/07 23:53:53, tkent wrote: > nit: ...
6 years, 3 months ago (2014-09-08 01:04:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/547563002/40001
6 years, 3 months ago (2014-09-08 01:48:36 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-08 02:09:25 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 181531

Powered by Google App Engine
This is Rietveld 408576698