Fix potential race-condition _beginthread

Fix potential race-condition _beginthread

Sometimes ppapi tests fails due to race condition.
It's safer to use _beginthreadex than _beginthread. If the thread
that's generated by _beginthread exits quickly, the handle that's
returned to the caller of _beginthread might be invalid or point to
another thread. However, the handle that's returned by _beginthreadex
has to be closed by the caller of _beginthreadex, so it is guaranteed
to be a valid handle if _beginthreadex did not return an error.

R=bbudge@chromium.org
BUG=

Committed: https://crrev.com/eaea4278689ac7f2919b60d65eda33cd4aa7cad2
Cr-Commit-Position: refs/heads/master@{#294541}

[bbudge, 2014-09-05 17:22:59]

https://codereview.chromium.org/547543002/diff/1/ppapi/tests/pp_thread.h
File ppapi/tests/pp_thread.h (right):

https://codereview.chromium.org/547543002/diff/1/ppapi/tests/pp_thread.h#newc...
ppapi/tests/pp_thread.h:41: struct PP_ThreadType {
Given that this is now a struct, PP_ThreadType doesn't seem like a great name.
How about PP_Thread? I think it's available, though you'd have to change 2 more
files that reference this.

https://codereview.chromium.org/547543002/diff/1/ppapi/tests/pp_thread.h#newc...
ppapi/tests/pp_thread.h:91: typedef DWORD (PP_WindowsThreadFunction)(void*
data);
This typedef doesn't appear to be used anywhere.

https://codereview.chromium.org/547543002/diff/1/ppapi/tests/pp_thread.h#newc...
ppapi/tests/pp_thread.h:93: PP_INLINE unsigned int __stdcall
ProxyThreadFunc(void* param) {
This is really an adapter or 'thunk' for the thread function. Could you name it
PP_WindowsThreadFunction? Also, I think the return type should be DWORD or just
unsigned.
http://msdn.microsoft.com/en-us/library/kdzttdcb.aspx

https://codereview.chromium.org/547543002/diff/1/ppapi/tests/pp_thread.h#newc...
ppapi/tests/pp_thread.h:107: 0,  /* Use default stack size. */
nit: indent is strange

[drbasic, 2014-09-11 03:28:29]

Please take a look.

[bbudge, 2014-09-11 14:06:01]

LGTM w/nit

https://codereview.chromium.org/547543002/diff/40001/ppapi/tests/pp_thread.h
File ppapi/tests/pp_thread.h (right):

https://codereview.chromium.org/547543002/diff/40001/ppapi/tests/pp_thread.h#...
ppapi/tests/pp_thread.h:93: PP_Thread* params =
reinterpret_cast<PP_Thread*>(param);
nit: name this 'thread'?

[drbasic, 2014-09-12 03:18:14]

The CQ bit was checked by drbasic@yandex-team.ru

[commit-bot: I haz the power, 2014-09-12 03:19:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/547543002/60001

[commit-bot: I haz the power, 2014-09-12 04:20:13]

Committed patchset #4 (id:60001) as 12451fcfaf980e139a8a1ae3a205de572ae38c1b

[commit-bot: I haz the power, 2014-09-12 04:21:57]

Patchset 4 (id:??) landed as
https://crrev.com/eaea4278689ac7f2919b60d65eda33cd4aa7cad2
Cr-Commit-Position: refs/heads/master@{#294541}