Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 547533006: GN: fix up //media/base linux dependencies (Closed)

Created:
6 years, 3 months ago by jamesr
Modified:
6 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GN: fix up //media/base linux dependencies media/base/user_input_monitor_linux.cc depends on //ui/gfx/x and //ui/events:events_base Committed: https://crrev.com/d107c91a6187e480f756848c66190ecdeda212c0 Cr-Commit-Position: refs/heads/master@{#293669}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M media/base/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
jamesr
6 years, 3 months ago (2014-09-05 18:25:57 UTC) #2
acolwell GONE FROM CHROMIUM
lgtm
6 years, 3 months ago (2014-09-05 19:56:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/547533006/1
6 years, 3 months ago (2014-09-05 20:03:40 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 03:03:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/547533006/1
6 years, 3 months ago (2014-09-06 06:14:30 UTC) #9
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 11:15:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/547533006/1
6 years, 3 months ago (2014-09-07 22:23:23 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as 83fbec943a8599976ebddde29f312b8707b21fe0
6 years, 3 months ago (2014-09-07 22:26:16 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:44:27 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d107c91a6187e480f756848c66190ecdeda212c0
Cr-Commit-Position: refs/heads/master@{#293669}

Powered by Google App Engine
This is Rietveld 408576698