Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 547523002: Stabilize PPB_View.GetScrollOffset (Closed)

Created:
6 years, 3 months ago by raymes
Modified:
6 years, 3 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Stabilize PPB_View.GetScrollOffset The dev marker is removed, making this a stable pepper API. The context around this decision can be found here: https://groups.google.com/a/chromium.org/forum/#!topic/pepper-dev/Dw-UGrTuYuI Committed: https://crrev.com/d719be84fe50994a310ccaa7d1f6cb9382e4bb42 Cr-Commit-Position: refs/heads/master@{#294056}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M ppapi/api/ppb_view.idl View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/ppb_view.h View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
raymes
6 years, 3 months ago (2014-09-05 01:37:10 UTC) #2
dmichael (off chromium)
Don't you also need to move it from interfaces_public_dev_channel.h to interfaces_public_stable.h? Also, if your e-mail ...
6 years, 3 months ago (2014-09-05 19:09:47 UTC) #3
raymes
I don't think so - that's the old ViewDev interface which we want to get ...
6 years, 3 months ago (2014-09-08 02:38:45 UTC) #5
teravest
There's no entry for a version of PPB_View in ppapi/thunk/interfaces_ppb_public_dev_channel.h, so there's nothing to change. ...
6 years, 3 months ago (2014-09-08 14:20:15 UTC) #6
dmichael (off chromium)
Oh, oops. I'm glad we decided it didn't need to change ;-) Agree with Justin, ...
6 years, 3 months ago (2014-09-08 15:16:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/547523002/1
6 years, 3 months ago (2014-09-09 03:41:19 UTC) #9
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-09 10:03:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/547523002/1
6 years, 3 months ago (2014-09-10 00:06:50 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as 070eb0e571ec0ae0ade47f2e800e7d7eed855d61
6 years, 3 months ago (2014-09-10 00:54:36 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:57:07 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d719be84fe50994a310ccaa7d1f6cb9382e4bb42
Cr-Commit-Position: refs/heads/master@{#294056}

Powered by Google App Engine
This is Rietveld 408576698