Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: net/disk_cache/blockfile/backend_impl.h

Issue 547513002: Remove disk_cache::BackendImpl::OpenPrevEntry() and all users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: narrower Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/disk_cache/blockfile/backend_impl.h
diff --git a/net/disk_cache/blockfile/backend_impl.h b/net/disk_cache/blockfile/backend_impl.h
index c2d91a73feedd58e1ba0bc9a3138f8ba3d5733f0..e2304ffdcd1339e1a493161b5e502c437f7d9937 100644
--- a/net/disk_cache/blockfile/backend_impl.h
+++ b/net/disk_cache/blockfile/backend_impl.h
@@ -66,10 +66,6 @@ class NET_EXPORT_PRIVATE BackendImpl : public Backend {
int SyncInit();
void CleanupCache();
- // Same behavior as OpenNextEntry but walks the list from back to front.
- int OpenPrevEntry(void** iter, Entry** prev_entry,
- const CompletionCallback& callback);
-
// Synchronous implementation of the asynchronous interface.
int SyncOpenEntry(const std::string& key, Entry** entry);
int SyncCreateEntry(const std::string& key, Entry** entry);
@@ -79,7 +75,6 @@ class NET_EXPORT_PRIVATE BackendImpl : public Backend {
base::Time end_time);
int SyncDoomEntriesSince(base::Time initial_time);
int SyncOpenNextEntry(void** iter, Entry** next_entry);
- int SyncOpenPrevEntry(void** iter, Entry** prev_entry);
void SyncEndEnumeration(void* iter);
void SyncOnExternalCacheHit(const std::string& key);
@@ -87,7 +82,6 @@ class NET_EXPORT_PRIVATE BackendImpl : public Backend {
EntryImpl* OpenEntryImpl(const std::string& key);
EntryImpl* CreateEntryImpl(const std::string& key);
EntryImpl* OpenNextEntryImpl(void** iter);
- EntryImpl* OpenPrevEntryImpl(void** iter);
// Sets the maximum size for the total amount of data stored by this instance.
bool SetMaxSize(int max_bytes);
@@ -314,13 +308,10 @@ class NET_EXPORT_PRIVATE BackendImpl : public Backend {
EntryImpl* MatchEntry(const std::string& key, uint32 hash, bool find_parent,
Addr entry_addr, bool* match_error);
- // Opens the next or previous entry on a cache iteration.
- EntryImpl* OpenFollowingEntry(bool forward, void** iter);
-
// Opens the next or previous entry on a single list. If successful,
// |from_entry| will be updated to point to the new entry, otherwise it will
// be set to NULL; in other words, it is used as an explicit iterator.
- bool OpenFollowingEntryFromList(bool forward, Rankings::List list,
+ bool OpenFollowingEntryFromList(Rankings::List list,
CacheRankingsBlock** from_entry,
EntryImpl** next_entry);

Powered by Google App Engine
This is Rietveld 408576698