Add many more content settings to be set in the Website Settings options

Add many more content settings to be set in the Website Settings options
page.

BUG=372607
Committed: https://crrev.com/946b66d67884e1a5ae8c63689696395255e060be
Cr-Commit-Position: refs/heads/master@{#293728}

[Daniel Nishi, 2014-09-04 23:11:39]

Patchset #1 (id:1) has been deleted

[Daniel Nishi, 2014-09-04 23:13:19]

Patchset #1 (id:20001) has been deleted

[Daniel Nishi, 2014-09-04 23:14:26]

dhnishi@chromium.org changed reviewers:
+ bauerb@chromium.org

[Daniel Nishi, 2014-09-04 23:14:27]

bauerb: PTAL.

[Bernhard Bauer, 2014-09-05 08:56:18]

https://codereview.chromium.org/547433002/diff/40001/chrome/app/generated_res...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/547433002/diff/40001/chrome/app/generated_res...
chrome/app/generated_resources.grd:7939: +        Runs scripts
Hm... we are only going to show content setting *exceptions* here, right? We
might need to tweak the UI somewhat to make that clear. I'll try to talk to
felt@ today to see if we can come up with something.

https://codereview.chromium.org/547433002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/options/website_settings_edit_page.js (right):

https://codereview.chromium.org/547433002/diff/40001/chrome/browser/resources...
chrome/browser/resources/options/website_settings_edit_page.js:128:
permissionNameSpan.textContent = loadTimeData.getString('websites' +
At this point it might be easier to either
a) write a proper conversion from dash-separated-style to CamelCase, or
b) just use a table that maps from one to the other.

[Daniel Nishi, 2014-09-05 18:02:39]

https://codereview.chromium.org/547433002/diff/40001/chrome/app/generated_res...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/547433002/diff/40001/chrome/app/generated_res...
chrome/app/generated_resources.grd:7939: +        Runs scripts
On 2014/09/05 08:56:18, Bernhard Bauer wrote:
> Hm... we are only going to show content setting *exceptions* here, right? We
> might need to tweak the UI somewhat to make that clear. I'll try to talk to
> felt@ today to see if we can come up with something.

These strings in particular are going to be exposed as part of the single site
view.

Google-internal mock:
https://folio.googleplex.com/chrome-ux/mocks/236-fizz/content-settings/090214...

https://codereview.chromium.org/547433002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/options/website_settings_edit_page.js (right):

https://codereview.chromium.org/547433002/diff/40001/chrome/browser/resources...
chrome/browser/resources/options/website_settings_edit_page.js:128:
permissionNameSpan.textContent = loadTimeData.getString('websites' +
On 2014/09/05 08:56:18, Bernhard Bauer wrote:
> At this point it might be easier to either
> a) write a proper conversion from dash-separated-style to CamelCase, or
> b) just use a table that maps from one to the other.

I've gone with b so we can have the flexibility to not have to name every string
based upon the string that maps to the Content Setting.

For example, geolocation goes often by "location" in these interfaces, but
"geolocation" in Content Settings string mapping.

[Bernhard Bauer, 2014-09-05 18:41:36]

bauerb@chromium.org changed reviewers:
+ felt@chromium.org

[Bernhard Bauer, 2014-09-05 18:41:36]

LGTM w/ a nit below

https://codereview.chromium.org/547433002/diff/40001/chrome/app/generated_res...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/547433002/diff/40001/chrome/app/generated_res...
chrome/app/generated_resources.grd:7939: +        Runs scripts
On 2014/09/05 18:02:39, Daniel Nishi wrote:
> On 2014/09/05 08:56:18, Bernhard Bauer wrote:
> > Hm... we are only going to show content setting *exceptions* here, right? We
> > might need to tweak the UI somewhat to make that clear. I'll try to talk to
> > felt@ today to see if we can come up with something.
> 
> These strings in particular are going to be exposed as part of the single site
> view.
> 
> Google-internal mock:
>
https://folio.googleplex.com/chrome-ux/mocks/236-fizz/content-settings/090214...

+felt

Ah, I was originally thinking of the site list. There it might make sense to
point out whether a site is allowed or blocked from running plugins / showing
images / whatever. We can do that in a follow up though.

https://codereview.chromium.org/547433002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/options/website_settings_edit_page.js (right):

https://codereview.chromium.org/547433002/diff/60001/chrome/browser/resources...
chrome/browser/resources/options/website_settings_edit_page.js:27:
'multiple-automatic-downloads': 'MultipleAutomaticDownloads',
If we have a custom mapping here anyway, could we abbreviate this to
"Downloads"?

[Daniel Nishi, 2014-09-05 19:21:39]

https://codereview.chromium.org/547433002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/options/website_settings_edit_page.js (right):

https://codereview.chromium.org/547433002/diff/60001/chrome/browser/resources...
chrome/browser/resources/options/website_settings_edit_page.js:27:
'multiple-automatic-downloads': 'MultipleAutomaticDownloads',
On 2014/09/05 18:41:36, Bernhard Bauer wrote:
> If we have a custom mapping here anyway, could we abbreviate this to
> "Downloads"?

Done.

[Daniel Nishi, 2014-09-05 19:22:05]

The CQ bit was checked by dhnishi@chromium.org

[commit-bot: I haz the power, 2014-09-05 19:23:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dhnishi@chromium.org/547433002/80001

[commit-bot: I haz the power, 2014-09-06 01:24:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-06 01:24:19]

Exceeded time limit waiting for builds to trigger.

[Daniel Nishi, 2014-09-08 15:14:12]

The CQ bit was checked by dhnishi@chromium.org

[commit-bot: I haz the power, 2014-09-08 15:17:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dhnishi@chromium.org/547433002/80001

[commit-bot: I haz the power, 2014-09-08 15:19:35]

Committed patchset #3 (id:80001) as a2a111a6c288aff99f463b54113da3109c9b1469

[commit-bot: I haz the power, 2014-09-10 03:46:23]

Patchset 3 (id:??) landed as
https://crrev.com/946b66d67884e1a5ae8c63689696395255e060be
Cr-Commit-Position: refs/heads/master@{#293728}