Source/platform/fonts/Font.h - Issue 54743004: Rendering text-justify:distribute for 8 bit characters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/Font.h

Issue 54743004: Rendering text-justify:distribute for 8 bit characters. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add the test case in the TestExpectaions as NeedsRebaseline Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/fonts/Font.h

diff --git a/Source/platform/fonts/Font.h b/Source/platform/fonts/Font.h

index 1e1e4961746db0f0c09234a71505ff96ba366442..fe5f22a1c7e1e291a70806994c542108df25d618 100644

--- a/Source/platform/fonts/Font.h

+++ b/Source/platform/fonts/Font.h

@@ -156,8 +156,8 @@ public:

static bool isCJKIdeograph(UChar32);

static bool isCJKIdeographOrSymbol(UChar32);

- static unsigned expansionOpportunityCount(const LChar*, size_t length, TextDirection, bool& isAfterExpansion);

- static unsigned expansionOpportunityCount(const UChar*, size_t length, TextDirection, bool& isAfterExpansion);

+ static unsigned expansionOpportunityCount(const LChar*, size_t length, TextDirection, bool& isAfterExpansion, bool distributeJustification);

+ static unsigned expansionOpportunityCount(const UChar*, size_t length, TextDirection, bool& isAfterExpansion, bool distributeJustification);

static void setShouldUseSmoothing(bool);

static bool shouldUseSmoothing();

« LayoutTests/TestExpectations ('K') | « Source/core/rendering/RenderBlockLineLayout.cpp ('k') | Source/platform/fonts/Font.cpp » ('j') | no next file with comments »