Source/core/rendering/InlineTextBox.cpp - Issue 54743004: Rendering text-justify:distribute for 8 bit characters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/InlineTextBox.cpp

Issue 54743004: Rendering text-justify:distribute for 8 bit characters. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add the test case in the TestExpectaions as NeedsRebaseline Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/TestExpectations ('K') | « LayoutTests/platform/linux/fast/css3-text/css3-text-justify/text-justify-8bits-expected.txt ('k') | Source/core/rendering/RenderBlockLineLayout.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/InlineTextBox.cpp

diff --git a/Source/core/rendering/InlineTextBox.cpp b/Source/core/rendering/InlineTextBox.cpp

index 60a35deccf1253ac5df7bbcae293e5ccc1ae2019..236fc24738a91f3c54eeeb0b9253dffebee47a70 100644

--- a/Source/core/rendering/InlineTextBox.cpp

+++ b/Source/core/rendering/InlineTextBox.cpp

@@ -1523,6 +1523,7 @@ TextRun InlineTextBox::constructTextRun(RenderStyle* style, const Font& font, St

TextRun run(string, textPos(), expansion(), expansionBehavior(), direction(), dirOverride() || style->rtlOrdering() == VisualOrder, !textRenderer->canUseSimpleFontCodePath());

run.setTabSize(!style->collapseWhiteSpace(), style->tabSize());

+ run.setDistributeJustification(style->textJustify() == TextJustifyDistribute);

if (textRunNeedsRenderingContext(font))

run.setRenderingContext(SVGTextRunRenderingContext::create(textRenderer));