Mojo: bindings connector

mojo/public/bindings/lib/message_queue.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MOJO_PUBLIC_BINDINGS_LIB_MESSAGE_QUEUE_H_
+#define MOJO_PUBLIC_BINDINGS_LIB_MESSAGE_QUEUE_H_
+
+#include <queue>
+
+#include "mojo/public/system/macros.h"
+
+namespace mojo {
+class Message;

[viettrungluu, 2013/11/06 18:29:34]

nit: blank line above?

+
+class MessageQueue {
+ public:
+  MessageQueue();
+  ~MessageQueue();
+
+  bool IsEmpty() const;
+  Message* Peek() const;

[viettrungluu, 2013/11/06 18:29:34]

Should this return a const Message* (or const Message&?), since it'd be weird
for the caller to be able to modify/swap out the contents of the peeked message.

+
+  void Push(Message* message);

[viettrungluu, 2013/11/06 18:29:34]

It might be good to have a comment indicating that |Push()| takes ownership of
the contents of |message| (but not of |message| itself), though maybe that's
clear due to the way that |Message| works.

+
+  void Pop(Message* message);
+  void Pop();
+
+ private:
+  std::queue<Message*> queue_;

[viettrungluu, 2013/11/06 18:29:34]

It's kind of sad that with Message being noncopyable, you end up having to
heap-allocate them to put them into a C++03 STL container. I don't see a good
way to avoid this though (short of C++11).... :(

+
+  MOJO_DISALLOW_COPY_AND_ASSIGN(MessageQueue);
+};
+
+}  // namespace mojo
+
+#endif  // MOJO_PUBLIC_BINDINGS_LIB_MESSAGE_QUEUE_H_