Issue 547423002: Fix creation of CrosPowerMonitor.

Issue 547423002: Fix creation of CrosPowerMonitor. (Closed)

Created:
6 years, 3 months ago by achuithb

Modified:
6 years, 3 months ago

Reviewers:
tonyg, tbarzic

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Fix creation of CrosPowerMonitor. BUG=410931 TEST=testSmoothness passes Committed: https://crrev.com/6a7bdfdc821b9688911a57df29dc1a6293de7516 Cr-Commit-Position: refs/heads/master@{#293830}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/telemetry/telemetry/core/platform/cros_platform_backend.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 10 (3 generated)

achuithb

Bug was introduced in this patch, where the ctor signature of CrosPowerMonitor was changed: https://codereview.chromium.org/509043002/

6 years, 3 months ago (2014-09-08 13:35:09 UTC) #2

tbarzic

On 2014/09/08 20:20:11, achuithb wrote: > Toni, please take a look. lgtm

6 years, 3 months ago (2014-09-08 20:21:58 UTC) #5

achuithb

On 2014/09/08 20:21:58, tbarzic wrote: > On 2014/09/08 20:20:11, achuithb wrote: > > Toni, please ...

6 years, 3 months ago (2014-09-08 20:23:12 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/547423002/1

6 years, 3 months ago (2014-09-08 20:23:57 UTC) #8

commit-bot: I haz the power

Committed patchset #1 (id:1) as 763aa10925cb13d9692d281f61531ac0dd2ce9e3

6 years, 3 months ago (2014-09-09 01:28:41 UTC) #9

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:49:35 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6a7bdfdc821b9688911a57df29dc1a6293de7516
Cr-Commit-Position: refs/heads/master@{#293830}